Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactor / update #13

Merged
merged 34 commits into from
Aug 29, 2022
Merged

Major refactor / update #13

merged 34 commits into from
Aug 29, 2022

Conversation

TomDonoghue
Copy link
Member

@TomDonoghue TomDonoghue commented Jun 23, 2022

This is a broad set of updates for the whole project, related in particular to consolidating

Broadly, this update includes:

  • working through all the current custom code in the repo, and removing as much as can be updated / replaced
  • updating code to use the updated / generalized functions from spiketools
  • working through & updating all scripts & notebooks with respect to the above
  • consolidating analyses on the new core set of analysis, and finishing / extending analyses to be ready to re-run

@TomDonoghue TomDonoghue changed the title [WIP] - Updates Major refactor / update Aug 8, 2022
scripts/settings.py Outdated Show resolved Hide resolved
Copy link
Contributor

@claire98han claire98han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomDonoghue - Thanks for the update, it's super helpful! left some comments on the scripts, and below are some minor comments on the notebooks. But in general, they all look great!

  • 00-DataChecks: tiny typo right before block 18, it should be 'select position only from navigation'
  • 02-PlaceCells & 03-SpatialTargetCells: I don't think we need to add a buffer to area_range for the actual analysis, even though it would be helpful to add it for visualization purposes.

code/models.py Outdated Show resolved Hide resolved
@TomDonoghue TomDonoghue merged commit 8c2e4e8 into main Aug 29, 2022
@TomDonoghue TomDonoghue deleted the load branch August 29, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants