Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency of area_range and optimal choice of bin size #12

Open
claire98han opened this issue Jun 17, 2022 · 2 comments
Open

Inconsistency of area_range and optimal choice of bin size #12

claire98han opened this issue Jun 17, 2022 · 2 comments

Comments

@claire98han
Copy link
Contributor

claire98han commented Jun 17, 2022

I noticed that there are different area_range used across analyses so just want to double-check on this.

Expectations:

  • nwbfile.acquisition['boundaries']['x_range'] and nwbfile.acquisition['boundaries']['z_range'] represent the x_boundary and z_boundary of the arena, which is fixed and identical in all nwb files.

Issues:

  • Player positions during the navigation period fall outside of the x_boundary and z_boundary range. See example in THF-wv004-0, where x_boundary, y_boundary = array([349.8549, 419.8549]), array([308. , 409.3358]). But from x_range, z_range = get_pos_ranges(positions_nav), x_range, z_range=[367.1234, 401.8272], [285.0, 433.0].

  • z_range is defined as nwbfile.acquisition['boundaries']['z_range'] + np. array([-10, 10]) in script, nwbfile.acquisition['boundaries']['z_range'] + np. array([-15, 15]) in 02-PlaceCells.ipynb. For place cell analysis, because the idea is to include data from the navigation period only, the buffer for tower transportation is not needed.

@TomDonoghue - could you please double-check these? Thanks!

@claire98han claire98han changed the title Inconsistency of area_range and optimal choices of bin size Inconsistency of area_range and optimal choice of bin size Jun 17, 2022
@claire98han
Copy link
Contributor Author

For the optimal choice of bin size, I'm thinking about defining bins such that each bin is a square. Currently, we are using bins = [6, 10] and chest_bins = [5, 7] which gives each bin a rectangular shape. Based on the range of the arena and chest_arena, it seems reasonable to have a 10-by-10 bin size.

@TomDonoghue
Copy link
Member

TomDonoghue commented Aug 29, 2022

Copying in notes from #13, as it's relevant here:

02-PlaceCells & 03-SpatialTargetCells: I don't think we need to add a buffer to area_range for the actual analysis, even though it would be helpful to add it for visualization purposes.
Related to unit_analysis.py, line 201:
area_range should be the chest area [[360, 410], [320, 400]] instead of the whole field range, right?

Bin sizes:

  • [5, 7] for all bins (place analysis)
  • [3, 5] for chest bins (target analysis)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants