Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build when http1 feature is disabled. #1002

Merged
merged 1 commit into from
Mar 28, 2024

fix build when http1 feature is disabled.

aa2b9b4
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix build when http1 feature is disabled. #1002

fix build when http1 feature is disabled.
aa2b9b4
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Mar 28, 2024 in 0s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.79.0-nightly (c9f8f3438 2024-03-27)
  • cargo 1.79.0-nightly (499a61ce7 2024-03-26)
  • clippy 0.1.79 (c9f8f34 2024-03-27)

Annotations

Check warning on line 135 in client/src/ws.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref 

warning: deref which would be done by auto-deref
   --> client/src/ws.rs:135:44
    |
135 |             ResponseBody::H1Owned(body) => &mut **body.conn(),
    |                                            ^^^^^^^^^^^^^^^^^^ help: try: `body.conn()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 133 in client/src/ws.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref 

warning: deref which would be done by auto-deref
   --> client/src/ws.rs:133:39
    |
133 |             ResponseBody::H1(body) => &mut **body.conn(),
    |                                       ^^^^^^^^^^^^^^^^^^ help: try: `body.conn()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
    = note: `#[warn(clippy::explicit_auto_deref)]` on by default

Check warning on line 135 in client/src/ws.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref 

warning: deref which would be done by auto-deref
   --> client/src/ws.rs:135:44
    |
135 |             ResponseBody::H1Owned(body) => &mut **body.conn(),
    |                                            ^^^^^^^^^^^^^^^^^^ help: try: `body.conn()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 133 in client/src/ws.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref 

warning: deref which would be done by auto-deref
   --> client/src/ws.rs:133:39
    |
133 |             ResponseBody::H1(body) => &mut **body.conn(),
    |                                       ^^^^^^^^^^^^^^^^^^ help: try: `body.conn()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
    = note: `#[warn(clippy::explicit_auto_deref)]` on by default

Check warning on line 279 in web/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item has both inner and outer attributes 

warning: item has both inner and outer attributes
   --> web/src/lib.rs:277:1
    |
277 | / #[cfg(feature = "codegen")]
278 | | pub mod codegen {
279 | |     //! macro code generation module.
    | |_____________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style
    = note: `#[warn(clippy::mixed_attributes_style)]` on by default

Check warning on line 52 in client/src/body.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference 

warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
  --> client/src/body.rs:52:28
   |
52 |     pub(crate) fn to_owned(self) -> ResponseBody<'static> {
   |                            ^^^^
   |
   = help: consider choosing a less ambiguous name
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
   = note: `#[warn(clippy::wrong_self_convention)]` on by default

Check warning on line 52 in client/src/body.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference 

warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
  --> client/src/body.rs:52:28
   |
52 |     pub(crate) fn to_owned(self) -> ResponseBody<'static> {
   |                            ^^^^
   |
   = help: consider choosing a less ambiguous name
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
   = note: `#[warn(clippy::wrong_self_convention)]` on by default

Check warning on line 279 in web/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item has both inner and outer attributes 

warning: item has both inner and outer attributes
   --> web/src/lib.rs:277:1
    |
277 | / #[cfg(feature = "codegen")]
278 | | pub mod codegen {
279 | |     //! macro code generation module.
    | |_____________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style
    = note: `#[warn(clippy::mixed_attributes_style)]` on by default

Check warning on line 44 in postgres/src/driver/generic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `take_rx` is never used 

warning: method `take_rx` is never used
  --> postgres/src/driver/generic.rs:44:19
   |
43 | impl DriverState {
   | ---------------- method in this implementation
44 |     pub(crate) fn take_rx(self) -> GenericDriverRx {
   |                   ^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 225 in http-ws/src/proto.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item has both inner and outer attributes 

warning: item has both inner and outer attributes
   --> http-ws/src/proto.rs:223:1
    |
223 | / #[cfg(test)]
224 | | mod test {
225 | |     #![allow(unused_imports, unused_variables, dead_code)]
    | |__________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style
    = note: `#[warn(clippy::mixed_attributes_style)]` on by default

Check warning on line 225 in http-ws/src/proto.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item has both inner and outer attributes 

warning: item has both inner and outer attributes
   --> http-ws/src/proto.rs:223:1
    |
223 | / #[cfg(test)]
224 | | mod test {
225 | |     #![allow(unused_imports, unused_variables, dead_code)]
    | |__________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style
    = note: `#[warn(clippy::mixed_attributes_style)]` on by default
View more details on GitHub Actions