Skip to content

fix build when http1 feature is disabled. #1566

fix build when http1 feature is disabled.

fix build when http1 feature is disabled. #1566

Triggered via pull request March 28, 2024 22:08
Status Success
Total duration 1m 21s
Artifacts

clippy-fmt.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

23 warnings
fmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
deref which would be done by auto-deref: client/src/ws.rs#L135
warning: deref which would be done by auto-deref --> client/src/ws.rs:135:44 | 135 | ResponseBody::H1Owned(body) => &mut **body.conn(), | ^^^^^^^^^^^^^^^^^^ help: try: `body.conn()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
deref which would be done by auto-deref: client/src/ws.rs#L133
warning: deref which would be done by auto-deref --> client/src/ws.rs:133:39 | 133 | ResponseBody::H1(body) => &mut **body.conn(), | ^^^^^^^^^^^^^^^^^^ help: try: `body.conn()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
deref which would be done by auto-deref: client/src/ws.rs#L135
warning: deref which would be done by auto-deref --> client/src/ws.rs:135:44 | 135 | ResponseBody::H1Owned(body) => &mut **body.conn(), | ^^^^^^^^^^^^^^^^^^ help: try: `body.conn()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
deref which would be done by auto-deref: client/src/ws.rs#L133
warning: deref which would be done by auto-deref --> client/src/ws.rs:133:39 | 133 | ResponseBody::H1(body) => &mut **body.conn(), | ^^^^^^^^^^^^^^^^^^ help: try: `body.conn()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
item has both inner and outer attributes: web/src/lib.rs#L277
warning: item has both inner and outer attributes --> web/src/lib.rs:277:1 | 277 | / #[cfg(feature = "codegen")] 278 | | pub mod codegen { 279 | | //! macro code generation module. | |_____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style = note: `#[warn(clippy::mixed_attributes_style)]` on by default
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference: client/src/body.rs#L52
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference --> client/src/body.rs:52:28 | 52 | pub(crate) fn to_owned(self) -> ResponseBody<'static> { | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `#[warn(clippy::wrong_self_convention)]` on by default
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference: client/src/body.rs#L52
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference --> client/src/body.rs:52:28 | 52 | pub(crate) fn to_owned(self) -> ResponseBody<'static> { | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `#[warn(clippy::wrong_self_convention)]` on by default
item has both inner and outer attributes: web/src/lib.rs#L277
warning: item has both inner and outer attributes --> web/src/lib.rs:277:1 | 277 | / #[cfg(feature = "codegen")] 278 | | pub mod codegen { 279 | | //! macro code generation module. | |_____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style = note: `#[warn(clippy::mixed_attributes_style)]` on by default
method `take_rx` is never used: postgres/src/driver/generic.rs#L44
warning: method `take_rx` is never used --> postgres/src/driver/generic.rs:44:19 | 43 | impl DriverState { | ---------------- method in this implementation 44 | pub(crate) fn take_rx(self) -> GenericDriverRx { | ^^^^^^^ | = note: `#[warn(dead_code)]` on by default
item has both inner and outer attributes: http-ws/src/proto.rs#L223
warning: item has both inner and outer attributes --> http-ws/src/proto.rs:223:1 | 223 | / #[cfg(test)] 224 | | mod test { 225 | | #![allow(unused_imports, unused_variables, dead_code)] | |__________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style = note: `#[warn(clippy::mixed_attributes_style)]` on by default
item has both inner and outer attributes: http-ws/src/proto.rs#L223
warning: item has both inner and outer attributes --> http-ws/src/proto.rs:223:1 | 223 | / #[cfg(test)] 224 | | mod test { 225 | | #![allow(unused_imports, unused_variables, dead_code)] | |__________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style = note: `#[warn(clippy::mixed_attributes_style)]` on by default
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/