Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Metacello platform attribute #pharo6.0 to the baseline #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chisandrei
Copy link

No description provided.

@dalehenrich
Copy link
Member

@chisandrei, please add a line to the .travis.yml file that adds Pharo6.0 to the lineup, so we can ensure that the tests are run and passing against Pharo6.0:

env:
  - GSCI_CLIENTS="Pharo-6.0"
  - GSCI_CLIENTS="Pharo-5.0"
  - GSCI_CLIENTS="Pharo-4.0 Pharo-3.0"

Thanks!

@dalehenrich
Copy link
Member

Hmm ... of course adding Pharo-6.0 to lineup, means that we need to have GsDevKit_home updated with the Pharo-6.0 download capability...I think I can add that pretty quickly ...

@dalehenrich
Copy link
Member

@dalehenrich
Copy link
Member

With my update for SmalltalkCI we're now down to the pharo6.0 download issue (exit 1 for --help) to get the travis tests running and see what other issues might exist :)

@dalehenrich
Copy link
Member

@chisandrei ... how's progress on the Pharo6.0 exit 1 issue? ... I suppose if there has been no progress, we could add Pharo6.0 to the expected failures section ... so at least we could get Pharo6.0 support into the master ... we just won;t be able to know whether or not we've broken pharo6.0 until an actual user reports a problem ... also I am forced to use Pharo5.0 because of this issue, so I won't see any Pharo6.0 issues ...

@chisandrei
Copy link
Author

I started a thread about this (http://forum.world.st/pharo-help-returns-exit-code-1-on-ubuntu-td4940486.html) but I do not think the fix is yet in the pharo vm.

@dalehenrich
Copy link
Member

@chisandrei what is your suggestion ... this is a "deal breaker" for using Pharo6.0 as far as I am concerned ... I cannot really run the download scripts without checking that pharo was actually installed correctly as it is too difficult to debug any pharo download problems after the download phase is complete ... and without a solution, we cannot us travis to validate pharo6.0 clients

@dalehenrich
Copy link
Member

@estebanlm are you aware of the issue with getting a non-zero exit code when using --help with pharo vm for pharo 6.0? It prevents me from using Pharo6.0 with GsDevKit_home, as I need a way to verify that the pharo vm is functional (all dependencies present) on a machine where X may not be installed ... --help has worked until Pharo6.0 and it isn't clear why the behavior was changed ...

@chisandrei
Copy link
Author

There is also a continuation of the thread on the vm mailing list: http://forum.world.st/Re-Pharo-dev-pharo-help-returns-exit-code-1-on-ubuntu-td4945756.html and a pull request https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/136/files. There were however some discussions related to other changes in the pull request.

@dalehenrich
Copy link
Member

dalehenrich commented Jan 26, 2019

Note that I am in the process of supporting Phar6.0, Pharo6.1, and Pharo7.0 (Issue #5)... in addition to getting Pharo5.0 working again ... I've basically got Pharo5.0 through Pharo6.1 going ... it took some changes to GsDevKit_home because the location for external modules was changed by the vm in the last 9 months or so ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants