-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit conversions #171
Merged
nmaarnio
merged 11 commits into
master
from
170-convert-radians-degrees-and-percent-rise-units
Aug 14, 2023
Merged
Added unit conversions #171
nmaarnio
merged 11 commits into
master
from
170-convert-radians-degrees-and-percent-rise-units
Aug 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transformed rad_to_rise to degree_to_rise which makes more sense in the context of working with slope values.
Set rad_to_rise as private fun _rad_to_rise.
nmaarnio
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nmaarnio
deleted the
170-convert-radians-degrees-and-percent-rise-units
branch
August 14, 2023 09:35
Hey Nico, thank you so much for reviewing all the requests 🐱🏍 I'm currently on the road 🌎 for another project and will continue work on EIS to finish the open parts when we're back next week 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality for converting radians into degree or percent rise for some surface derivatives like slope or aspect.
Please check if the structure for the toolkit integration is okay or if some changes my be needed.