Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit conversions #171

Merged
merged 11 commits into from
Aug 14, 2023

Conversation

msmiyels
Copy link
Collaborator

Added functionality for converting radians into degree or percent rise for some surface derivatives like slope or aspect.

Please check if the structure for the toolkit integration is okay or if some changes my be needed.

@msmiyels msmiyels added the enhancement New feature or request label Jul 25, 2023
@msmiyels msmiyels self-assigned this Jul 25, 2023
@msmiyels msmiyels linked an issue Jul 25, 2023 that may be closed by this pull request
msmiyels and others added 6 commits July 31, 2023 16:08
Transformed rad_to_rise to degree_to_rise which makes more sense in the context of working with slope values.
Set rad_to_rise as private fun _rad_to_rise.
@msmiyels msmiyels marked this pull request as ready for review August 1, 2023 11:57
Copy link
Collaborator

@nmaarnio nmaarnio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nmaarnio nmaarnio merged commit cf2f067 into master Aug 14, 2023
5 checks passed
@nmaarnio nmaarnio deleted the 170-convert-radians-degrees-and-percent-rise-units branch August 14, 2023 09:35
@msmiyels
Copy link
Collaborator Author

Hey Nico,

thank you so much for reviewing all the requests 🐱‍🏍 I'm currently on the road 🌎 for another project and will continue work on EIS to finish the open parts when we're back next week 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert radians, degrees and percent rise units
2 participants