Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99 create surface derivatives #172

Closed
wants to merge 21 commits into from
Closed

Conversation

msmiyels
Copy link
Collaborator

@msmiyels msmiyels commented Aug 4, 2023

Draft for slope and aspect computation in a 3x3 window.
Also added a functionality for classifiying the aspect into 8 or 16 classes (users's choice).

Also provided a small notebook with some example runs.

Utilities

Conversions

Can be integrated as an additional option in the GUI/Toolkit for user access.

  • convert_rad_to_deg()
  • convert_deg_to_rise()
  • convert_deg_to_rad()
  • convert_rise_to_deg()
  • _convert_rad_to_rise() this is private since should not be accessed by users or the GUI

These functions are the same as in Pull Request for #171 and included to provide full functionality.

Surface Attributes

Partial Derivatives

Needed as basic calculations for every kind of surface derivations included into EIS.
These are based on 3x3 window sizes. However, the code is structured in a way so that other methods or modifications (like 5x5 windows or other basic parameter set from other authors) could be added quite easily.

  • method_horn()
  • method_zevenbergen()

Surface Parameters

  • get_slope() and _get_slope()
  • get_aspect() and _get_aspect()
    • _mask_aspect()
    • _classify_aspect()

Partial derivatives are the preparation for the following curvatuve calculations.

Please check this approach so far, I would then continue to integrate the curvature sets.

@msmiyels msmiyels linked an issue Aug 4, 2023 that may be closed by this pull request
4 tasks
@msmiyels msmiyels self-assigned this Aug 4, 2023
@msmiyels msmiyels requested a review from nmaarnio August 4, 2023 06:27
@nmaarnio
Copy link
Collaborator

Hi @msmiyels and sorry for delayed review on this one. I could review this very soon, but I wonder if something went wrong with this PR as there are so many conflicts for files that do not concern the features of this PR? Would it be possible for you to either merge the master branch so that only relevant modifications are left or if that will get too complicated, create a new branch from the current master branch where you add only the the relevant modifications and additions?

@msmiyels
Copy link
Collaborator Author

Hi @nmaarnio. Don´t worry ;) I'm currently on my second parental leave but I'm back at the end of next week. I did not change the files without association to the derivates, so not sure what's going on at this point. Also think that it might be the easiest way to set-up a new branch and copy the additions or modifications to existing files (e.g. for exceptions, if those).

Would that be okay for you? I'll also finish the other (started but still open) parts (curv's and some smoothing stuff) as fast as possible during october.

cheers,
michael

@nmaarnio
Copy link
Collaborator

nmaarnio commented Oct 5, 2023

Yes, I think it would be easiest if you set up a new branch that is freshly made from master. Thanks!

sync before opening new branch
@msmiyels msmiyels closed this Oct 9, 2023
@nmaarnio nmaarnio deleted the 99-create-surface-derivatives branch February 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create surface derivatives
2 participants