Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change label filter intervention contractors and filter null value on project contractors detail view (ref #3820) #4061

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

juggler31
Copy link
Contributor

@juggler31 juggler31 commented Apr 9, 2024

…lue on project contractor detail view (ref #3820)

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@juggler31 juggler31 linked an issue Apr 9, 2024 that may be closed by this pull request
@juggler31 juggler31 requested a review from a team April 9, 2024 13:11
Copy link
Member

@babastienne babastienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog ?

Is the translation of "Contractors" or does it need to be generated ?

@juggler31 juggler31 force-pushed the modifs_on_prestataires branch 3 times, most recently from 740ca2c to d929c52 Compare April 9, 2024 13:21
@juggler31 juggler31 changed the title 🐛 fix: change label filter intervention contractor and filter null value on project contractor detail view (ref #3820) 🐛 fix: change label filter intervention contractors and filter null value on project contractors detail view (ref #3820) Apr 9, 2024
@juggler31 juggler31 requested a review from babastienne April 9, 2024 13:21
Copy link

cypress bot commented Apr 9, 2024

Passing run #8741 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 270a269 into 6bc4231...
Project: Geotrek-admin Commit: f2ba8ef074 ℹ️
Status: Passed Duration: 02:16 💡
Started: Apr 12, 2024 2:44 PM Ended: Apr 12, 2024 2:46 PM

Review all test suite changes for PR #4061 ↗︎

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (0ccf922) to head (270a269).
Report is 1 commits behind head on master.

❗ Current head 270a269 differs from pull request most recent head f36d080. Consider uploading reports for the commit f36d080 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4061      +/-   ##
==========================================
- Coverage   98.39%   98.39%   -0.01%     
==========================================
  Files         284      284              
  Lines       20785    20777       -8     
==========================================
- Hits        20451    20443       -8     
  Misses        334      334              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcantoinedupre marcantoinedupre self-requested a review April 11, 2024 09:38
@juggler31 juggler31 force-pushed the modifs_on_prestataires branch 2 times, most recently from cf03a53 to 270a269 Compare April 12, 2024 14:33
@juggler31 juggler31 force-pushed the modifs_on_prestataires branch from 270a269 to f36d080 Compare April 12, 2024 14:46
@juggler31 juggler31 merged commit aa572f7 into master Apr 12, 2024
10 checks passed
@juggler31 juggler31 deleted the modifs_on_prestataires branch April 12, 2024 14:47
@babastienne babastienne changed the title 🐛 fix: change label filter intervention contractors and filter null value on project contractors detail view (ref #3820) Change label filter intervention contractors and filter null value on project contractors detail view (ref #3820) May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#32 - Ajouter un champs "Prestataires" sur les interventions
3 participants