Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPR] Add contractor to intervention model (#3820) #3928

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

juggler31
Copy link
Contributor

@juggler31 juggler31 commented Feb 7, 2024

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@juggler31 juggler31 marked this pull request as draft February 7, 2024 17:12
Copy link

cypress bot commented Feb 7, 2024

Passing run #8022 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge e23f1e9 into 566db8c...
Project: Geotrek-admin Commit: fd0a91a7b1 ℹ️
Status: Passed Duration: 02:10 💡
Started: Feb 19, 2024 3:14 PM Ended: Feb 19, 2024 3:16 PM

Review all test suite changes for PR #3928 ↗︎

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (566db8c) 98.34% compared to head (e23f1e9) 98.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3928   +/-   ##
=======================================
  Coverage   98.34%   98.35%           
=======================================
  Files         294      294           
  Lines       22274    22286   +12     
=======================================
+ Hits        21906    21919   +13     
+ Misses        368      367    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juggler31 juggler31 force-pushed the add_presatataire_to_interventions branch from e00a2ad to 5ec61b8 Compare February 8, 2024 14:15
@juggler31 juggler31 force-pushed the add_presatataire_to_interventions branch from 5ec61b8 to a20bb25 Compare February 8, 2024 14:48
@juggler31 juggler31 linked an issue Feb 8, 2024 that may be closed by this pull request
@juggler31 juggler31 changed the title Add presatataire to interventions 💫 [IMPR] Add contractor to intervention model (#3820) Feb 8, 2024
@juggler31 juggler31 force-pushed the add_presatataire_to_interventions branch from a20bb25 to 481d879 Compare February 8, 2024 14:57
@juggler31 juggler31 marked this pull request as ready for review February 8, 2024 14:57
@juggler31 juggler31 requested a review from a team February 8, 2024 14:57
@juggler31 juggler31 force-pushed the add_presatataire_to_interventions branch 2 times, most recently from 7ca5bd3 to 518cee0 Compare February 12, 2024 10:30
docs/changelog.rst Outdated Show resolved Hide resolved
@juggler31 juggler31 force-pushed the add_presatataire_to_interventions branch 3 times, most recently from 252c772 to 43382fc Compare February 15, 2024 18:44
@juggler31 juggler31 force-pushed the add_presatataire_to_interventions branch from 43382fc to 34c2abb Compare February 16, 2024 11:08
@juggler31 juggler31 force-pushed the add_presatataire_to_interventions branch 3 times, most recently from 4d8fe72 to fc1228a Compare February 19, 2024 10:34
@juggler31 juggler31 force-pushed the add_presatataire_to_interventions branch from fc1228a to e23f1e9 Compare February 19, 2024 15:02
@juggler31 juggler31 merged commit a67a2f5 into master Feb 19, 2024
15 checks passed
@juggler31 juggler31 deleted the add_presatataire_to_interventions branch February 19, 2024 15:49
@babastienne babastienne changed the title 💫 [IMPR] Add contractor to intervention model (#3820) [IMPR] Add contractor to intervention model (#3820) Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#32 - Ajouter un champs "Prestataires" sur les interventions
3 participants