Remove Scientific_workflows and Tests from Sandbox sync #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This git sync script is more of deployment/run time specific configuration but build in the image. Can we raise a new issue ticket to look at when we have a time :) For now approved |
NikitaGandhi
approved these changes
Sep 16, 2021
|
Is this one relevant to that @NikitaGandhi? #172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #195 and #100 by adding the
Scientific_workflowsfolder to the list of items to be removed before syncing DEA Notebooks content to the home directory of the DEA Sandbox. This will ensure that beginner users are not exposed to experimental or broken code.In preparation for the addition of automated tests in
dea-notebooks, this PR also removes theTestsdirectory (see here) from the automatic sync so that this is also not exposed to users.Finally, this PR also adds
README.rstin addition toREADME.mdto account for the different file formats used in DEA and DE Africa.Please let me know if there's a better way to achieve this!