Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scientific_workflows should not be synced to the DEA Sandbox #100

Closed
robbibt opened this issue Jul 31, 2020 · 2 comments · Fixed by #196
Closed

Scientific_workflows should not be synced to the DEA Sandbox #100

robbibt opened this issue Jul 31, 2020 · 2 comments · Fixed by #196
Labels
bug Something isn't working

Comments

@robbibt
Copy link
Member

robbibt commented Jul 31, 2020

The Scientific_workflows folder appears to be being synced on the Sandbox:

image

This folder was originally excluded from the folders that were synced to the Sandbox, as it contains larger scripts/sample data that won't work without additional set up. This causes issues if e.g. if a new user naively tries to use any of that code inside the Sandbox, as none of the code will work. This will lead to a poor user experience.

To avoid this, this folder should be excluded from the automatic sync.
(this was originally the case after the DEA Notebooks refresh earlier this year, but it seems to have reverted at some point)

@robbibt robbibt added the bug Something isn't working label Jul 31, 2020
@alexgleith
Copy link
Contributor

This is where the folder needs to be added: https://github.com/GeoscienceAustralia/dea-sandbox/blob/develop/docker/assets/sync_repo

It's not a nice process though... pretty convoluted. Potentially needs cleaning up, @whatnick. Thoughts?

@robbibt
Copy link
Member Author

robbibt commented Jul 31, 2020

Ah, OK! Does that one script work for both DEAfrica and DEA Sandbox? We should probably be excluding DEA_notebooks_template.ipynb too, not just the equivalent in Africa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants