Added DeviceRendererFactory typing #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OoDeLally
commented
Aug 2, 2024
index.d.ts
Outdated
| activeKeyMappingDebug(isTraceActivate?: boolean, isGridActivate?: boolean): void; | ||
| }; | ||
|
|
||
| type VmEvent = 'beforeunload' | 'fingerprint' | 'gps' | 'BATTERY_LEVEL' | string // TODO Provide an exhaustive list |
There was a problem hiding this comment.
From what I've found, there are a few other events that are listed in the tests, but I don't know yet if the tests are exhaustive. Here are all values found in the tests:
ANDROID_ID
baseband
battery
BATTERY_STATUS
BLK
CLIPBOARD
diskio
fingerprint
framework
gps
IMEI
NETWORK
network_profile
settings
SYSTEM_PATCHER_LAST_RESULT
SYSTEM_PATCHER_STATUS
systempatcher
I'm trying to find a source of truth for these, either in the cloud player, maybe libcom repo, or something else.
[edit] by looking for occurences of registerEventCallback I've also found these:
BATTERY_LEVEL
vinput
OoDeLally
commented
Aug 2, 2024
index.d.ts
Outdated
|
|
||
| type VmCommunication = { | ||
| disconnect(): void; | ||
| addEventListener(event: VmEvent, callback: (msg: string) => void): void; // TODO Verify if msg is always string |
There was a problem hiding this comment.
From what I've found in the code for now, all values for msg where strings
OoDeLally
commented
Aug 2, 2024
index.d.ts
Outdated
| type VmCommunication = { | ||
| disconnect(): void; | ||
| addEventListener(event: VmEvent, callback: (msg: string) => void): void; // TODO Verify if msg is always string | ||
| sendData(data: { channel: string; messages: string[] }): void; // TODO Verify typing |
OoDeLally
commented
Aug 2, 2024
jparez
reviewed
Aug 2, 2024
index.d.ts
Outdated
| | 'CLIPBOARD' | ||
| | 'diskio' | ||
| | 'fingerprint' | ||
| | 'fingerprint' |
jparez
reviewed
Aug 2, 2024
index.d.ts
Outdated
| | 'fingerprint' | ||
| | 'framework' | ||
| | 'gps' | ||
| | 'gps' |
jparez
approved these changes
Aug 2, 2024
pgivel
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some typings for the device renderer.
Type of change
Checklist