Added typing #87
Closed
Added typing #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgivel
reviewed
Aug 1, 2024
| | 'renderer_no_toolbar' | ||
| | 'renderer_partial'; | ||
|
|
||
| interface Options { |
There was a problem hiding this comment.
small question on the Options type: will we be able to override it from the Shadow repo? There are a few more options that are set in the Shadow player compared to the Geny player.
pgivel
reviewed
Aug 1, 2024
index.d.ts
Outdated
| giveFeedbackLink?: string; | ||
| } | ||
|
|
||
| type DeviceRenderer = { |
There was a problem hiding this comment.
I guess this isn't exactly the DeviceRenderer, but rather the API? Does this typing handle the fact that some methods can be available or not depending on which plugins were instanciated?
|
Closed in favor of #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed if any. Please also include relevant motivation and context (a screenshot is appreciated).
Fixes #
Type of change
Checklist