-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brms examples for non-linear model #425
Conversation
Unit Tests Summary 1 files 179 suites 6m 10s ⏱️ Results for commit 546eb55. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit ca96482 ♻️ This comment has been updated with latest results. |
@gowerc For the brms examples I noticed the estimates are not near the diagonals like the jmpost ones are. Is that expected? jmpost modelbrms model |
@gravesti - That is not expected ... Will double check and update accordingly |
@gravesti - I think the code is fine (ish) I think its just super sensitive to starting values. Most of the time I run the brms code I get the correct output as expected: But every now and again I do get plots similar to what you showed, in these instances the sampler completes in about 10% of the usual time and the diagnostics are completely off. Running with longer warmups seems to correct this. |
Thanks @gowerc Maybe worth a note in the script for posterity to say that the models are sensitive to initial values are require a good warmup phase? |
@gravesti - Added a stronger warning message to highlight this. |
Code Coverage Summary
Diff against main
Results for commit: 546eb55 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Closes #417
Also moved a bunch of older stuff that I don't think is relevant anymore to a "legacy" folder to clean up the design area a bit