Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1363 challenge portal footer #1450

Merged
merged 4 commits into from
Oct 22, 2024
Merged

1363 challenge portal footer #1450

merged 4 commits into from
Oct 22, 2024

Conversation

jairoanaya
Copy link
Contributor

@jairoanaya jairoanaya commented Oct 22, 2024 •
edited by kkrug
Loading

Description

Added footer based on Challenge Platform - related card #1363

Related Issues

None

Changes Made

  • Updated CSS
  • Added Images
  • Added layout _footerv2.html.eex
  • Updated layout root.html.eex

Screenshots (if applicable)

See card https://github.com/orgs/GSA/projects/150/views/1?filterQuery=jairo&pane=issue&itemId=70215803&issue=GSA%7CChallenge_gov%7C1363

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • New functionality is tested and all tests are green
  • I have added unit tests for new functionality or updated existing tests for changes.
  • I have updated the documentation/README accordingly, if necessary.
  • If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
  • If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.

@jairoanaya jairoanaya added this to the Sprint 10/22/24 milestone Oct 22, 2024
@jairoanaya jairoanaya requested a review from kkrug October 22, 2024 00:37
@jairoanaya jairoanaya self-assigned this Oct 22, 2024
@r-bartlett-gsa r-bartlett-gsa linked an issue Oct 22, 2024 that may be closed by this pull request
Challenge Portal Footer #1363
Closed
33 tasks
@kkrug kkrug merged commit cb468ea into staging Oct 22, 2024
5 checks passed
@kkrug kkrug deleted the 1363-challenge-portal-footer branch October 22, 2024 16:50
@kkrug kkrug restored the 1363-challenge-portal-footer branch October 22, 2024 18:08
@kkrug kkrug mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrug kkrug kkrug approved these changes

Assignees

@jairoanaya jairoanaya

Labels
None yet
Projects
None yet
Milestone
Sprint 10/22/24
Development

Successfully merging this pull request may close these issues.

Challenge Portal Footer
3 participants
@jairoanaya @kkrug @jdonis