Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge Portal Footer #1363

Closed
30 of 33 tasks
r-bartlett-gsa opened this issue Jul 8, 2024 · 11 comments · Fixed by #1450 or #1457
Closed
30 of 33 tasks

Challenge Portal Footer #1363

r-bartlett-gsa opened this issue Jul 8, 2024 · 11 comments · Fixed by #1450 or #1457
Assignees

Comments

@r-bartlett-gsa
Copy link
Member

r-bartlett-gsa commented Jul 8, 2024

Note: This work needs to be deployed to challenge portal eval dev environment (challenge_gov repo > eval main branch)

User Story

As a site user with challenge manager or public solver roles, in order to build my trust using challenge.gov site, I would like to see consistent branding and styling from any page of the site.

Acceptance criteria:

  • Challenge.gov footer is displayed for logged-in users using challenge management and submissions portal

Definition of Done

Doing (dev team)

  • Code complete
  • Code is organized appropriately
  • Any known trade offs are documented in the associated GH issue
  • Code is documented, modules, shared functions, etc.
    - [ ] Automated testing has been added or updated in response to changes in this PR
  • The feature is smoke tested to confirm it meets requirements
    - [ ] Database changes have been peer reviewed for index changes and performance bottlenecks
  • PR that changes or adds UI
    • include a screenshot of the WAVE report for the altered pages
    • Confirm changes were validated for mobile responsiveness
  • PR approved / Peer reviewed
  • Security scans passed
    - [ ] Automate accessibility tests passed
  • Build process and deployment is automated and repeatable
    - [ ] Feature toggles if appropriate
  • Deploy to staging
  • Move card to testing column in the board

Staging

  • Accessibility tested (Marni)
    • Keyboard navigation
    • Focus confirmed
    • Color contrast compliance
    • Screen reader testing
  • Usability testing: mobile and desktop (Tracy or Marni)
  • Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)
    • Windows/Chrome
    • Windows/Edge
    • Mac/Chrome
    • Mac/Safari
    • iOS/Safari
  • AC review (Renata)
  • Deploy to production (production-like environment for eval capability) (dev team)
  • Move to production column in the board

Production

  • User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
  • PO / PM approved (Jarah or Renata)
  • AC is met and it works as expected (Jarah or Renata)
  • Move to done column in the board (Jarah or Renata)
@r-bartlett-gsa
Copy link
Member Author

@jairoanaya
Copy link
Contributor

Trade offs: no

Wave Report

Image

Responsive Evidence

Image

@r-bartlett-gsa r-bartlett-gsa linked a pull request Oct 22, 2024 that will close this issue
10 tasks
@kkrug kkrug linked a pull request Oct 22, 2024 that will close this issue
10 tasks
@kkrug kkrug linked a pull request Oct 23, 2024 that will close this issue
10 tasks
@jairoanaya jairoanaya linked a pull request Oct 23, 2024 that will close this issue
10 tasks
@jairoanaya
Copy link
Contributor

jairoanaya commented Oct 23, 2024

Work done:

  • Code understanding from challenge_platform
  • Code was adapted from challenge_platform
  • Team feedback document created on Google - https://docs.google.com/document/d/1m9GDKig5K_8mTU-F_xMwHaz7KfCrCLLX1_fGh-WqsCc/edit?usp=drive_link
  • Team feedback for implementation
  • CSS update
  • Testing in Desktop and Responsive
  • Deploying into staging
  • Feature ready for testing on staging
  • Branch recreation from eval - new instruction
  • Testing in Desktop and Responsive locally
  • Feature ready for testing on eval-main staging (pending approved PR for deployment on eval staging)

Notes:

Due to a new branching instruction - a new branch was recreated from eval-main in order to deploy the feature into Eval version. Previous branches were deleted or archived.

@jairoanaya
Copy link
Contributor

All manual validation passed.
This card is ready to test on https://challenge-portal-eval-dev.app.cloud.gov/

@r-bartlett-gsa
Copy link
Member Author

r-bartlett-gsa commented Oct 24, 2024

@jairoanaya Please check appropriate boxes in the Definition of Done list. If some of these items do not apply, please strike them out.
Here's a screenshot of that list: Image

Also, in you earlier comment you mention "Documentation created on Google". What does that mean?

@jairoanaya
Copy link
Contributor

@r-bartlett-gsa Feedback has been addressed.

@mhotch24
Copy link
Contributor

mhotch24 commented Oct 25, 2024

@r-bartlett-gsa All passed testing. The only "issues" are the font and location of Contact Us is slightly off and the GSA Challenge.gov watermark is smaller.

See comparison:
Image
Image
Image
Image

@jairoanaya
Copy link
Contributor

Scheduled for maintenance.

@r-bartlett-gsa
Copy link
Member Author

@jairoanaya If you are referring to Marni's notes as scheduled for maintenance, please do not work on that at this time. We will address styling and design consistencies at a later time, during fit & finish stage before these updates go live. I consider this story as done.

@jairoanaya
Copy link
Contributor

Yes. You are correct! I confirm that I will not work on this item at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment