[Copy] Updates admin page with job advertisement information

apps/playwright/tests/admin/process-action-create.spec.ts

@@ -49,15 +49,15 @@ test("Create pool", async ({ appPage }) => {
     .selectOption({ label: "IT-04 (Information Technology)" });
 
   await appPage.page
-    .getByRole("textbox", { name: /job title \(en\)/i })
+    .getByRole("textbox", { name: /job title \(english\)/i })
     .fill(`${PROCESS_TITLE} (EN)`);
 
   await appPage.page
-    .getByRole("textbox", { name: /job title \(fr\)/i })
+    .getByRole("textbox", { name: /job title \(french\)/i })
     .fill(`${PROCESS_TITLE} (FR)`);
 
   await appPage.page
-    .getByRole("combobox", { name: /length of opportunity/i })
+    .getByRole("combobox", { name: /employment duration/i })
     .selectOption({ label: "Various" });
 
   await appPage.page
@@ -78,7 +78,7 @@ test("Create pool", async ({ appPage }) => {
     .click();
 
   const closingDate = appPage.page.getByRole("group", {
-    name: /end date/i,
+    name: /closing date/i,
   });
   await closingDate.getByRole("spinbutton", { name: /year/i }).fill("2500");
   await closingDate

apps/playwright/tests/admin/process-action-update.spec.ts

@@ -27,10 +27,10 @@ test.describe("Update pool", () => {
       .getByRole("button", { name: /edit advertisement details/i })
       .click();
     await appPage.page
-      .getByRole("textbox", { name: /job title \(en\)/i })
+      .getByRole("textbox", { name: /job title \(english\)/i })
       .fill("Update pool test (EN)");
     await appPage.page
-      .getByRole("textbox", { name: /job title \(fr\)/i })
+      .getByRole("textbox", { name: /job title \(french\)/i })
       .fill("Update pool test (FR)");
     await appPage.page
       .getByRole("combobox", { name: /work stream/i })
@@ -54,7 +54,7 @@ test.describe("Update pool", () => {
       .click();
 
     const closingDate = appPage.page.getByRole("group", {
-      name: /end date/i,
+      name: /closing date/i,
     });
     await closingDate.getByRole("spinbutton", { name: /year/i }).fill("2500");
     await closingDate

apps/web/src/components/ToggleForm/NullDisplay.tsx

@@ -30,8 +30,8 @@ const NullDisplay = ({ title, content, optional }: NullDisplayProps) => {
                 description: "Null message on sections for edit pool page.",
               })
             : intl.formatMessage({
-                defaultMessage: "You haven't filled this information out yet.",
-                id: "xsIcls",
+                defaultMessage: "You haven't filled out this information yet.",
+                id: "D3so/C",
                 description: "Null message on sections for edit pool page.",
               })}
         </p>

apps/web/src/messages/processMessages.ts

@@ -16,20 +16,20 @@ const messages = defineMessages({
     id: "9pYlYz",
     description: "Label for a process' stream",
   },
-  opportunityLength: {
-    defaultMessage: "Length of opportunity",
-    id: "08rkLr",
-    description: "Label for a process' opportunity employment duration",
+  employmentDuration: {
+    defaultMessage: "Employment duration",
+    id: "0Z7Ux8",
+    description: "Label for process employment duration",
   },
   titleEn: {
-    defaultMessage: "Specific title (English)",
-    id: "QISMlC",
-    description: "Label for a process' English title",
+    defaultMessage: "Job title (English)",
+    id: "FMPqfb",
+    description: "Label for process English title",
   },
   titleFr: {
-    defaultMessage: "Specific title (French)",
-    id: "m7ppfC",
-    description: "Label for a process' French title",
+    defaultMessage: "Job title (French)",
+    id: "r9cJmW",
+    description: "Label for process French title",
   },
   processNumber: {
     defaultMessage: "Process number",

apps/web/src/pages/Pools/EditPoolPage/EditPoolPage.tsx

@@ -471,8 +471,8 @@ export const EditPoolForm = ({
         whatToExpectAdmission: pool.whatToExpectAdmission,
       }), // Add understanding classification (#8831) validation here
       title: intl.formatMessage({
-        defaultMessage: "Common questions",
-        id: "RahVQS",
+        defaultMessage: "More information",
+        id: "sGT8ER",
         description: "Title for common questions",
       }),
       subtitle: intl.formatMessage({

apps/web/src/pages/Pools/EditPoolPage/components/ClosingDateSection/ClosingDateDialog.tsx

@@ -46,47 +46,40 @@ const ClosingDateDialog = ({ title }: { title: ReactNode }): JSX.Element => {
           })}
         </Dialog.Header>
         <Dialog.Body>
-          <div
-            data-h2-display="base(flex)"
-            data-h2-gap="base(x.5)"
-            data-h2-flex-direction="base(column)"
-            data-h2-align-items="base(flex-start)"
-          >
-            <p>
-              {intl.formatMessage({
+          <p data-h2-margin-bottom="base(x.5)">
+            {intl.formatMessage({
+              defaultMessage:
+                "In order to provide an equitable opportunity for all Canadians to apply to a position, deadlines close at <strong>11:59PM Pacific time</strong> on the date you select. When shown to applicants, we ask them to apply on or before the date you've chosen to avoid confusion around time zones.",
+              id: "9EnhFG",
+              description: "First paragraph for the pool closing date dialog",
+            })}
+          </p>
+          <p data-h2-margin-bottom="base(x.5)">
+            {intl.formatMessage({
+              defaultMessage:
+                "For example, if the deadline chosen is March 1st, 2024, applicants would see “Apply on or before March 1st, 2024”, with a hard deadline of 11:59PM Pacific time. For an applicant in the Eastern time zone, this would mean that they can technically apply before 2:59AM on March 2nd.",
+              id: "C9jYms",
+              description: "Second paragraph for pool closing date dialog",
+            })}
+          </p>
+          <p>
+            {intl.formatMessage(
+              {
                 defaultMessage:
-                  "In order to provide an equitable opportunity for all Canadians to apply to a position, deadlines close at <strong>11:59PM Pacific time</strong> on the date you select. When shown to applicants, we ask them to apply on or before the date you've chosen to avoid confusion around time zones.",
-                id: "9EnhFG",
-                description: "First paragraph for the pool closing date dialog",
-              })}
-            </p>
-            <p>
-              {intl.formatMessage({
-                defaultMessage:
-                  "For example, if the deadline chosen is March 1st, 2024, applicants would see “Apply on or before March 1st, 2024”, with a hard deadline of 11:59PM Pacific time. For an applicant in the Eastern time zone, this would mean that they can technically apply before 2:59AM on March 2nd.",
-                id: "C9jYms",
-                description: "Second paragraph for pool closing date dialog",
-              })}
-            </p>
-            <p data-h2-display="base(flex)">
-              {intl.formatMessage(
-                {
-                  defaultMessage:
-                    "Have further questions? Feel free to <link>reach out to our team</link> for more information.",
-                  id: "07p+1J",
-                  description: "Third paragraph for pool closing date dialog",
-                },
-                {
-                  link: (chunks: ReactNode) =>
-                    generateLink(
-                      routes.support(),
-                      { referrer: window.location.href },
-                      chunks,
-                    ),
-                },
-              )}
-            </p>
-          </div>
+                  "Have further questions? Feel free to <link>reach out to our team</link> for more information.",
+                id: "07p+1J",
+                description: "Third paragraph for pool closing date dialog",
+              },
+              {
+                link: (chunks: ReactNode) =>
+                  generateLink(
+                    routes.support(),
+                    { referrer: window.location.href },
+                    chunks,
+                  ),
+              },
+            )}
+          </p>
           <Dialog.Footer>
             <Dialog.Close>
               <Button color="secondary">

apps/web/src/pages/Pools/EditPoolPage/components/ClosingDateSection/ClosingDateSection.tsx

@@ -22,13 +22,13 @@ import {
 } from "@gc-digital-talent/graphql";
 
 import useDeepCompareEffect from "~/hooks/useDeepCompareEffect";
-import { getExperienceFormLabels } from "~/utils/experienceUtils";
 import {
   hasEmptyRequiredFields,
   hasInvalidRequiredFields,
 } from "~/validators/process/closingDate";
 import useToggleSectionInfo from "~/hooks/useToggleSectionInfo";
 import ToggleForm from "~/components/ToggleForm/ToggleForm";
+import processMessages from "~/messages/processMessages";
 
 import { useEditPoolContext } from "../EditPoolContext";
 import Display from "./Display";
@@ -68,7 +68,6 @@ const ClosingDateSection = ({
   onSave,
 }: ClosingDateSectionProps): JSX.Element => {
   const intl = useIntl();
-  const experienceFormLabels = getExperienceFormLabels(intl);
   const pool = getFragment(EditPoolClosingDate_Fragment, poolQuery);
   const emptyRequired = hasEmptyRequiredFields(pool);
   const invalidRequired = hasInvalidRequiredFields(pool);
@@ -169,7 +168,7 @@ const ClosingDateSection = ({
               <div data-h2-margin-bottom="base(x1)">
                 <DateInput
                   id="endDate"
-                  legend={experienceFormLabels.endDate}
+                  legend={intl.formatMessage(processMessages.closingDate)}
                   name="endDate"
                   disabled={formDisabled}
                   rules={{

apps/web/src/pages/Pools/EditPoolPage/components/CoreRequirementsSection/CoreRequirementsSection.tsx

@@ -146,8 +146,8 @@ const CoreRequirementsSection = ({
 
   const subtitle = intl.formatMessage({
     defaultMessage:
-      "This section covers requirements such as remote work, on-site locations, language and security.",
-    id: "LKZV/V",
+      "This section covers requirements such as remote work, on-site locations, language, and security.",
+    id: "+qkjh+",
     description: "Describes selecting additional requirements for a process.",
   });
 
@@ -219,8 +219,8 @@ const CoreRequirementsSection = ({
                       name="specificLocationEn"
                       type="text"
                       label={intl.formatMessage({
-                        defaultMessage: "Specific Location (English)",
-                        id: "A2VzLX",
+                        defaultMessage: "Specific location (English)",
+                        id: "bEY1qp",
                         description:
                           "Label for a pool advertisements specific English Location",
                       })}
@@ -244,8 +244,8 @@ const CoreRequirementsSection = ({
                       name="specificLocationFr"
                       type="text"
                       label={intl.formatMessage({
-                        defaultMessage: "Specific Location (French)",
-                        id: "PH+6C9",
+                        defaultMessage: "Specific location (French)",
+                        id: "4tGRa+",
                         description:
                           "Label for a pool advertisements specific French Location",
                       })}

apps/web/src/pages/Pools/EditPoolPage/components/EssentialSkillsSection.tsx

@@ -99,8 +99,8 @@ const EssentialSkillsSection = ({
 
   const subtitle = intl.formatMessage({
     defaultMessage:
-      "Select the skills that you are looking for in applicants. Any skill selected here will be required for any applicant to apply. To increase the diversity of applications try to keep the selected number of skills to a minimum.",
-    id: "VKvAfu",
+      "Select the skills that you're looking for in applicants. Skills selected here are required for an applicant to be considered for the role. To increase the diversity of applications, please try to keep the selected number of skills to a minimum.",
+    id: "7gTBjD",
     description: "Describes selecting essentials skills for a process.",
   });
 

apps/web/src/pages/Pools/EditPoolPage/components/PoolNameSection/Display.tsx

@@ -136,7 +136,7 @@ const Display = ({
         </ToggleForm.FieldDisplay>
         <ToggleForm.FieldDisplay
           hasError={!opportunityLength}
-          label={intl.formatMessage(processMessages.opportunityLength)}
+          label={intl.formatMessage(processMessages.employmentDuration)}
         >
           {getLocalizedName(opportunityLength?.label, intl)}
         </ToggleForm.FieldDisplay>

apps/web/src/pages/Pools/EditPoolPage/components/PoolNameSection/PoolNameSection.tsx

@@ -289,8 +289,8 @@ const PoolNameSection = ({
 
   const subtitle = intl.formatMessage({
     defaultMessage:
-      "This section covers the process' basics, including classification, job title, and closing date.",
-    id: "pQGDiR",
+      "This section covers the process's basics, including classification, job title, and closing date.",
+    id: "7Yacsa",
     description: "Describes selecting a advertisement details for a process.",
   });
 
@@ -405,24 +405,14 @@ const PoolNameSection = ({
                   id="specificTitleEn"
                   name="specificTitleEn"
                   type="text"
-                  label={intl.formatMessage({
-                    defaultMessage: "Job title (EN)",
-                    id: "XiODnT",
-                    description:
-                      "Label for a pool advertisements specific English title",
-                  })}
+                  label={intl.formatMessage(processMessages.titleEn)}
                   disabled={formDisabled}
                 />
                 <Input
                   id="specificTitleFr"
                   name="specificTitleFr"
                   type="text"
-                  label={intl.formatMessage({
-                    defaultMessage: "Job title (FR)",
-                    id: "bkAzZm",
-                    description:
-                      "Label for a pool advertisements specific French title",
-                  })}
+                  label={intl.formatMessage(processMessages.titleFr)}
                   disabled={formDisabled}
                 />
               </div>
@@ -444,7 +434,7 @@ const PoolNameSection = ({
                 <Select
                   id="opportunityLength"
                   name="opportunityLength"
-                  label={intl.formatMessage(processMessages.opportunityLength)}
+                  label={intl.formatMessage(processMessages.employmentDuration)}
                   nullSelection={intl.formatMessage(
                     uiMessages.nullSelectionOption,
                   )}
@@ -459,11 +449,7 @@ const PoolNameSection = ({
                   id="processNumber"
                   name="processNumber"
                   type="text"
-                  label={intl.formatMessage({
-                    defaultMessage: "Process Number",
-                    id: "1E0RiD",
-                    description: "Label for a pools process number",
-                  })}
+                  label={intl.formatMessage(processMessages.processNumber)}
                   context={intl.formatMessage({
                     defaultMessage:
                       "This process number is obtained from your HR shop",

apps/web/src/pages/Pools/EditPoolPage/components/WhatToExpectAdmissionSection/WhatToExpectAdmissionSection.tsx

@@ -125,8 +125,8 @@ const WhatToExpectAdmissionSection = ({
 
   const subtitle = intl.formatMessage({
     defaultMessage:
-      'This question helps applicants understand what it means to be in a recruitment "pool" and what they should expect as qualified candidates.',
-    id: "Q2uL2b",
+      "This information helps applicants understand what it means to be in a recruitment process and what they should expect as qualified candidates.",
+    id: "zLuuVe",
     description:
       "Describes the 'what to expect after admission' section of a process' advertisement.",
   });

apps/web/src/pages/Pools/EditPoolPage/components/WhatToExpectSection/WhatToExpectSection.tsx

@@ -119,8 +119,8 @@ const WhatToExpectSection = ({
 
   const subtitle = intl.formatMessage({
     defaultMessage:
-      "This information lets applicants know what they can expect after they apply, such as further exams, meeting with managers directly and possible timelines.",
-    id: "ww+trY",
+      "This information lets applicants know what they can expect after they apply, such as further exams, meeting with managers directly, and possible timelines.",
+    id: "+/ZsxX",
     description:
       "Describes the 'what to expect after applying' section of a process' advertisement.",
   });

packages/i18n/src/lang/fr.json

@@ -331,6 +331,10 @@
     "defaultMessage": "Région de l'Ontario (excluant Ottawa)",
     "description": "The work region of Canada described as Ontario."
   },
+  "CYirJF": {
+    "defaultMessage": "Vous devez indiquer le lieu précis en anglais et en français si l'annonce ne vise pas un poste à distance.",
+    "description": "Error message that advertisement locations must be filled in English and French."
+  },
   "ChFxsM": {
     "defaultMessage": "Région de l'Atlantique (Nouveau-Brunswick, Terre-Neuve-et-Labrador, Nouvelle-Écosse et Île-du-Prince-Édouard.)",
     "description": "The work region of Canada described as Atlantic."
@@ -847,10 +851,6 @@
     "defaultMessage": "Jour",
     "description": "Label for a day of the month input field"
   },
-  "aMkZ80": {
-    "defaultMessage": "Vous devez indiquer le lieu précis en anglais et en français si l’annonce ne vise pas un poste à distance.",
-    "description": "Error message that advertisement locations must be filled in English and French."
-  },
   "aTHtqQ": {
     "defaultMessage": "Obtention d’un diplôme",
     "description": "Option for education requirement, graduation with degree"

packages/i18n/src/messages/apiMessages.ts

@@ -279,8 +279,8 @@ export const apiMessages: Record<string, MessageDescriptor> = defineMessages({
   },
   PoolLocationRequired: {
     defaultMessage:
-      "You must fill Specific Location in English and French if advertisement is not remote.",
-    id: "aMkZ80",
+      "You must fill Specific location in English and French if advertisement is not remote.",
+    id: "CYirJF",
     description:
       "Error message that advertisement locations must be filled in English and French.",
   },