Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Copy] Updates admin page with job advertisement information #12485

Merged
merged 26 commits into from
Jan 16, 2025
Merged

[Copy] Updates admin page with job advertisement information #12485

merged 26 commits into from
Jan 16, 2025

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Jan 14, 2025 •
edited
Loading

🤖 Resolves #12420.

👋 Introduction

This PR updates English and French copy on the admin page with job advertisement information.

🧪 Testing

  1. pnpm build:fresh
  2. Create a process
  3. Verify English and French copy changes have been made based on the linked issue description

📸 Screenshots

Screenshots (6)

localhost_8000_en_admin_pools_26c55796-176e-46f1-8895-0c187b9fa403_edit (1)
localhost_8000_en_admin_pools_26c55796-176e-46f1-8895-0c187b9fa403_edit
localhost_8000_fr_admin_pools_26c55796-176e-46f1-8895-0c187b9fa403_edit (1)
localhost_8000_fr_admin_pools_26c55796-176e-46f1-8895-0c187b9fa403_edit

Screen Shot 2025-01-14 at 10 42 47 Screen Shot 2025-01-14 at 10 43 09

mnigh and others added 24 commits January 13, 2025 16:31
@mnigh
Update French copy
265db6c
@mnigh
Update English Describes selecting a advertisement details for a process
b0e69cb
@mnigh
Update and consolidate Label for process English, French title
57c15d8
@mnigh
Replace opportunityLength with employmentDuration
0ac832b
@mnigh
Update English Null message on sections for edit pool page
b6cd6db
@mnigh
Update legend to use processMessages.closingDate
847e8a6
@mnigh
Fix container
d205a1c
@mnigh
Remove space
78dfb1c
@mnigh
Update Subtitle for the pool closing date dialog
d0b3755
@mnigh
Update First paragraph for the pool closing date dialog
b4d537f
@mnigh
Update Second paragraph for pool closing date dialog
53632ee
@mnigh
Update Describes selecting additional requirements for a process
1a2a2b5
@mnigh
Update to sentence case
6598b55
@mnigh
Update Describes selecting essentials skills for a process
5be2f41
@mnigh
Update Sub title for basic information
01cc8e5
@mnigh
Update Describes the 'your impact' section of a process' advertisement
810d674
@mnigh
Update Describes the 'work tasks' section of a process' advertisement
c14f0bc
@mnigh
Update Title for common questions
61f34a5
@mnigh
Update Sub title for common questions
886ea98
@mnigh
Update Describes the 'what to expect after applying' section of a pro…
c56d199 
…cess' advertisement
@mnigh
Updates Describes the 'what to expect after admission' section of a p…
c599f31 
…rocess' advertisement
@mnigh
Update playwright tests
f4ffd6a
@mnigh
Update playwright test
2ea22e7
@mnigh
Merge branch 'main' into 12420-copy-advertisement-admin
1d9781c
@mnigh mnigh requested a review from NienkeBr January 14, 2025 17:27
esizer
esizer approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

NienkeBr
NienkeBr approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@NienkeBr NienkeBr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I spotted two more small points, if they can also still be included, it'd be awesome!

  • Would you mind to make "Process number" sentence case?
    image

  • Could we also change this to "aux candidates et candidats"?
    image

@mnigh
Copy link
Contributor Author

mnigh commented Jan 15, 2025

Would you mind to make "Process number" sentence case?

14d6ae5

Screenshot

Screen Shot 2025-01-14 at 19 33 01

Could we also change this to "aux candidates et candidats"?

2bd7a75

Screenshot

Screen Shot 2025-01-14 at 19 33 45

@mnigh mnigh requested review from NienkeBr and esizer January 15, 2025 00:35
@mnigh mnigh added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit d39a60a Jan 16, 2025
15 checks passed
@mnigh mnigh deleted the 12420-copy-advertisement-admin branch January 16, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NienkeBr NienkeBr NienkeBr approved these changes

@esizer esizer esizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔤 Copy updates to Advertisement information admin page
3 participants
@mnigh @esizer @NienkeBr