Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Copy] Change to sentence case; remove superfluous colons; update English and French copy #12378

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Dec 24, 2024

🤖 Resolves #12335.

👋 Introduction

This PR makes some copy fixes on the search request page and view request page, primarily issues of title case to sentence case, but also some other fixes to English copy and some French edits. It also removes all the colons from the labels in both languages (FilterBlock component) and updates some other text for consistency.

🧪 Testing

  1. pnpm build:fresh
  2. Navigate to Search request page
  3. Verify English and French copy matches requested changes in linked issue
  4. Navigate to View request page
  5. Verify English and French copy matches requested changes in linked issue

📸 Screenshots

Search request page

English

localhost_8000_en_search_request

French

localhost_8000_fr_search_request

View request page

English

localhost_8000_en_admin_talent-requests_f32bf6c5-a890-4e8e-8326-57d9e38050c3

French

localhost_8000_fr_admin_talent-requests_f32bf6c5-a890-4e8e-8326-57d9e38050c3

Other Screen Shot 2024-12-24 at 13 53 49 Screen Shot 2024-12-24 at 13 55 00 Screen Shot 2024-12-24 at 13 55 31

@mnigh mnigh requested a review from NienkeBr December 24, 2024 19:34
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@NienkeBr NienkeBr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed one more point I'd like to have updated, if I can still add it here.
On the search request page, could we change "Department/Hiring organization" and "Ministère/organisation d'embauche" to "Department or hiring organization" and "Ministère ou organisation d'embauche"?
image
image

apps/web/src/lang/fr.json Outdated Show resolved Hide resolved
@mnigh
Copy link
Contributor Author

mnigh commented Dec 27, 2024

I noticed one more point I'd like to have updated, if I can still add it here. On the search request page, could we change "Department/Hiring organization" and "Ministère/organisation d'embauche" to "Department or hiring organization" and "Ministère ou organisation d'embauche"?

Screenshots

localhost_8000_en_search

localhost_8000_fr_search_request

@mnigh mnigh requested review from esizer and NienkeBr December 27, 2024 16:18
@mnigh mnigh added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 6ef9044 Dec 27, 2024
15 checks passed
@mnigh mnigh deleted the 12335-copy-fixes branch December 27, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔤 Small copy fixes talent request details admin side
3 participants