Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fault_proving(global_roots): populate ProcessedTransactions table #2650

Merged
merged 4 commits into from
Feb 5, 2025
Merged

fault_proving(global_roots): populate ProcessedTransactions table #2650

merged 4 commits into from
Feb 5, 2025

Conversation

netrome
Copy link
Contributor

@netrome netrome commented Jan 29, 2025 •
edited
Loading

Closes #2583

@netrome netrome changed the title 2583 fault provingglobal roots populate processedtransactions table fault_proving(global_roots): populate ProcessedTransactions table Jan 29, 2025
@netrome netrome force-pushed the 2583-fault_provingglobal_roots-populate-processedtransactions-table branch from b1cbd67 to 4cb48c4 Compare January 29, 2025 20:40
@netrome netrome self-assigned this Jan 29, 2025
@netrome netrome force-pushed the 2582-fault_provingglobal_roots-initial-test-suite-for-storage-updates branch from 2457f06 to bbf6361 Compare January 31, 2025 20:51
Base automatically changed from 2582-fault_provingglobal_roots-initial-test-suite-for-storage-updates to master January 31, 2025 21:11
@netrome netrome force-pushed the 2583-fault_provingglobal_roots-populate-processedtransactions-table branch from 4cb48c4 to 0c85f8f Compare February 2, 2025 12:59
@netrome netrome linked an issue Feb 2, 2025 that may be closed by this pull request
fault_proving(global_roots): Populate ProcessedTransactions table #2583
Closed
@netrome netrome marked this pull request as ready for review February 2, 2025 13:00
@netrome netrome force-pushed the 2583-fault_provingglobal_roots-populate-processedtransactions-table branch from 0c85f8f to d3e9c9e Compare February 5, 2025 08:18
rymnc
rymnc reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments!

@netrome netrome force-pushed the 2583-fault_provingglobal_roots-populate-processedtransactions-table branch from 765c9fc to 5dc7e60 Compare February 5, 2025 08:34
@netrome netrome requested a review from rymnc February 5, 2025 08:35
acerone85
acerone85 requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@acerone85 acerone85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test not compiling locally. The rest of the PR is good :)

@netrome netrome force-pushed the 2583-fault_provingglobal_roots-populate-processedtransactions-table branch from 7a37b17 to 63394f6 Compare February 5, 2025 10:40
@netrome netrome mentioned this pull request Feb 5, 2025
Merged
@netrome netrome force-pushed the 2583-fault_provingglobal_roots-populate-processedtransactions-table branch from 63394f6 to 4a681b6 Compare February 5, 2025 10:50
@netrome netrome requested a review from acerone85 February 5, 2025 10:50
@netrome netrome force-pushed the 2583-fault_provingglobal_roots-populate-processedtransactions-table branch from 4a681b6 to 524a2ae Compare February 5, 2025 10:57
@netrome netrome merged commit c53a265 into master Feb 5, 2025
33 checks passed
@netrome netrome deleted the 2583-fault_provingglobal_roots-populate-processedtransactions-table branch February 5, 2025 11:30
@AurelienFT AurelienFT mentioned this pull request Feb 5, 2025
Merged
AurelienFT added a commit that referenced this pull request Feb 5, 2025
@AurelienFT
Release 0.41.6 (#2674)
4ff324b 
## Version 0.41.6

### Added
- [2668](#2668): Expose gas
price service test helpers
- [2621](#2598): Global merkle
root storage updates process upgrade transactions.
- [2650](#2650): Populate
`ProcessedTransactions` table in global merkle root storage.
- [2667](#2667): Populate
`Blobs` table in global merkle root storage.
- [2652](#2652): Global Merkle
Root storage crate: Add Raw contract bytecode to global merkle root
storage when processing Create transactions.

### Fixed
- [2673](#2673): Change read
behavior on the InMemoryTransaction to use offset and allow not equal
buf size (fix CCP and LDC broken from
FuelLabs/fuel-vm#847)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acerone85 acerone85 acerone85 approved these changes

@rymnc rymnc rymnc approved these changes

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

@rafal-ch rafal-ch Awaiting requested review from rafal-ch rafal-ch is a code owner

@AurelienFT AurelienFT Awaiting requested review from AurelienFT AurelienFT is a code owner

Assignees

@netrome netrome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fault_proving(global_roots): Populate ProcessedTransactions table
3 participants
@netrome @acerone85 @rymnc