Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fault_proving(global_roots): Populate UploadedBytecodes table #2669

Merged
merged 5 commits into from
Feb 6, 2025
Merged

fault_proving(global_roots): Populate UploadedBytecodes table #2669

merged 5 commits into from
Feb 6, 2025

Conversation

netrome
Copy link
Contributor

@netrome netrome commented Feb 4, 2025

closes #2585

@netrome netrome linked an issue Feb 4, 2025 that may be closed by this pull request
fault_proving(global_roots): Populate UploadedBytecodes table #2585
Closed
@netrome netrome self-assigned this Feb 4, 2025
@netrome netrome force-pushed the 2585-fault_provingglobal_roots-populate-uploadedbytecodes-table branch from c7c41a4 to 3347f1c Compare February 4, 2025 20:30
acerone85
acerone85 requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@acerone85 acerone85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests not compiling, feature needs to be imported

@netrome
Copy link
Contributor Author

netrome commented Feb 5, 2025

Tests not compiling, feature needs to be imported

Yeah same as in #2650 - will be fixed when I rebase this.

@netrome netrome force-pushed the 2585-fault_provingglobal_roots-populate-uploadedbytecodes-table branch from 3347f1c to 418d068 Compare February 5, 2025 13:24
@netrome netrome requested a review from acerone85 February 5, 2025 13:25
acerone85
acerone85 previously approved these changes Feb 5, 2025
View reviewed changes
@netrome netrome marked this pull request as ready for review February 5, 2025 13:33
@netrome netrome requested a review from acerone85 February 5, 2025 14:02
@netrome netrome force-pushed the 2585-fault_provingglobal_roots-populate-uploadedbytecodes-table branch from 012189c to 6f71426 Compare February 6, 2025 10:55
@netrome netrome enabled auto-merge (squash) February 6, 2025 18:37
@netrome netrome merged commit 66d4ece into master Feb 6, 2025
32 checks passed
@netrome netrome deleted the 2585-fault_provingglobal_roots-populate-uploadedbytecodes-table branch February 6, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

@acerone85 acerone85 acerone85 approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

@rafal-ch rafal-ch Awaiting requested review from rafal-ch rafal-ch is a code owner

@rymnc rymnc Awaiting requested review from rymnc rymnc is a code owner

@AurelienFT AurelienFT Awaiting requested review from AurelienFT AurelienFT is a code owner

Assignees

@netrome netrome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fault_proving(global_roots): Populate UploadedBytecodes table
3 participants
@netrome @xgreenx @acerone85