Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(tap) Added chaoticlab CNC tap settings. #632

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jackmoxley
Copy link

Adding the choatic lab cnc probe, which has a higher threshold as it is more prone to failure on gantry checking and height maps.

It used the base voron_tap, so all the macros and pin settings remain.

@EricZimmerman
Copy link
Collaborator

Why is this needed vs just straight up overriding the [probe] block?

# Conflicts:
#	config/hardware/probes/chaoticlab-cnc-tap-v2.cfg
@jackmoxley
Copy link
Author

Why is this needed vs just straight up overriding the [probe] block?

I did exactly that, but in the nature of providing out the box support for everyone that uses these mods, I thought it would be helpful.

You could say the same thing about anny klippain config file.

Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

1 similar comment
Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants