Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CNC Taps #635

Closed
jackmoxley opened this issue Jul 30, 2024 · 4 comments
Closed

Add support for CNC Taps #635

jackmoxley opened this issue Jul 30, 2024 · 4 comments
Labels
enhancement New feature or request stale Issue that appear to be inactive, mark for potenial closing if stale for longer time triage This is a new issue to be sorted (automatic label)

Comments

@jackmoxley
Copy link

jackmoxley commented Jul 30, 2024

Describe the feature or hardware support you'd like

Choatic Labs CNC tap, can't handle the sensitivity the default tap is given in the config. So I would like a specialised config that meets the manufactorers settings. I have added a PR to do just that #632

Additional context or information

The change is taken directly from https://github.com/Chaoticlab/CNC-Tap-for-Voron/blob/master/Manual/CNC%20Tap%20V2.cfg but adjusted to match Klippain setup

@jackmoxley jackmoxley added enhancement New feature or request triage This is a new issue to be sorted (automatic label) labels Jul 30, 2024
@Surion79
Copy link
Collaborator

Surion79 commented Aug 7, 2024

You can add this in your override. I have also cnc tap of chaoticslab and it works fine with the klippain default settings.
We can only provide one set of settings via klippain in the config sections. Individual changes must be put in overrides.
I don't see the need to add it.

@jackmoxley
Copy link
Author

I can, I was merely adding the manufacturers recommendations. If you don't want it feel free to close.

Copy link

📌 This issue has been marked as stale because it has not had activity in the past 30 days.
To keep it open, please respond to this message or add new information. Otherwise, this will be closed in 14 days.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue that appear to be inactive, mark for potenial closing if stale for longer time label Sep 11, 2024
Copy link

This issue was closed due to inactivity for 14 days. Feel free to reopen it if you think it was an error or if you have new information or progress to share

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issue that appear to be inactive, mark for potenial closing if stale for longer time triage This is a new issue to be sorted (automatic label)
Projects
None yet
Development

No branches or pull requests

2 participants