Fix MQTT_Status_strerror to return correct error on NeedMoreBytes err…

…or (#255) * Fix timeout calculation to account for overflow * Add unit tests to check for overflow * Update timeout value in UT * Fix formatting * Update core_mqtt_utest.c * Add one more unit test to check for one corner case * Make unit-test more robust * Fix MQTT_Status_strerror to return correct error on NeedMoreBytes error.
FreeRTOS · Jun 26, 2023 · c5a1efe · c5a1efe
1 parent 0df6f49
commit c5a1efe
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/source/core_mqtt.c b/source/core_mqtt.c
@@ -3373,6 +3373,10 @@ const char * MQTT_Status_strerror( MQTTStatus_t status )
             str = "MQTTKeepAliveTimeout";
             break;
 
+        case MQTTNeedMoreBytes:
+            str = "MQTTNeedMoreBytes";
+            break;
+
         default:
             str = "Invalid MQTT Status code";
             break;

diff --git a/test/unit-test/core_mqtt_utest.c b/test/unit-test/core_mqtt_utest.c
@@ -5842,7 +5842,11 @@ void test_MQTT_Status_strerror( void )
     str = MQTT_Status_strerror( status );
     TEST_ASSERT_EQUAL_STRING( "MQTTKeepAliveTimeout", str );
 
-    status = MQTTKeepAliveTimeout + 1;
+    status = MQTTNeedMoreBytes;
+    str = MQTT_Status_strerror( status );
+    TEST_ASSERT_EQUAL_STRING( "MQTTNeedMoreBytes", str );
+
+    status = MQTTNeedMoreBytes + 1;
     str = MQTT_Status_strerror( status );
     TEST_ASSERT_EQUAL_STRING( "Invalid MQTT Status code", str );
 }