Fix sending empty strings in MQTT packets (#252)

The assert that checks that non-zero lengths have non-NULL pointers currently also inadvertently checks that zero lengths have NULL pointers.
FreeRTOS · May 26, 2023 · 0df6f49 · 0df6f49
1 parent b0acf49
commit 0df6f49
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/source/core_mqtt.c b/source/core_mqtt.c
@@ -1866,7 +1866,7 @@ static size_t addEncodedStringToVector( uint8_t serializedLength[ CORE_MQTT_SERI
     size_t vectorsAdded = 0U;
 
     /* When length is non-zero, the string must be non-NULL. */
-    assert( ( length != 0U ) == ( string != NULL ) );
+    assert( ( length != 0U ) ? ( string != NULL ) : true );
 
     serializedLength[ 0 ] = ( ( uint8_t ) ( ( length ) >> 8 ) );
     serializedLength[ 1 ] = ( ( uint8_t ) ( ( length ) & 0x00ffU ) );