Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make groups&items propagations twice faster, do not join groups table to determine group memberships, do not mark new items for propagation + testing-related fixes #1210

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Make groups&items propagations twice faster, do not join groups table to determine group memberships, do not mark new items for propagation + testing-related fixes #1210

wants to merge 12 commits into from

Commits on Nov 6, 2024

  1. add and initialize a new column groups_groups.is_team_membership

    @zenovich
    zenovich committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7198eb6 View commit details
    Browse the repository at this point in the history

  2. modify trigger before_insert_groups_groups to set groups_groups.is_te… 

    …am_membership
    @zenovich
    zenovich committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8b88353 View commit details
    Browse the repository at this point in the history

  3. modify trigger before_update_groups_groups to disallow modifying grou… 

    …ps_groups.is_team_membership
    @zenovich
    zenovich committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    cf5c1f2 View commit details
    Browse the repository at this point in the history

  4. do not mark groups for propagation on changing team memberships

    @zenovich
    zenovich committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7cf492d View commit details
    Browse the repository at this point in the history

  5. add trigger before_update_groups to disallow modifying groups.type

    @zenovich
    zenovich committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3c23612 View commit details
    Browse the repository at this point in the history

  6. add/modify tests for triggers, fix tests to support groups_groups.is_… 

    …team_membership
    @zenovich
    zenovich committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8962d59 View commit details
    Browse the repository at this point in the history

  7. change the DB username for migration-tests to match the definer of tr… 

    …iggers in the dump file
    @zenovich
    zenovich committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8e9bcf2 View commit details
    Browse the repository at this point in the history

  8. make groups&items propagations twice faster: 1) move the 'processing'… 

    … state into a new temporary table, 2) always filter *_propagate tables by exact values of ancestors_propagation_state, 3) perform covering index lookups on groups_groups instead of index lookups (create an index for this)
    @zenovich
    zenovich committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    621ed68 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. sort all the data returned by currentUserDataExport & currentUserFull… 

    …DataExport to make tests stable
    @zenovich
    zenovich committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    89e27c8 View commit details
    Browse the repository at this point in the history

  2. add is_team_membership column to groups_groups_active view

    @zenovich
    zenovich committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    373af70 View commit details
    Browse the repository at this point in the history

  3. do not join the groups table to detect team membership, use the group… 

    …s_groups.is_team_membership column instead
    @zenovich
    zenovich committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c8c74c8 View commit details
    Browse the repository at this point in the history

  4. drop unnecessary trigger after_insert_items as there is no reason for… 

    … marking a newly created item as "todo" for items propagation, only call the items propagation in itemCreate if new items_items rows are created
    @zenovich
    zenovich committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    add7e16 View commit details
    Browse the repository at this point in the history