Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make groups&items propagations twice faster, do not join groups table to determine group memberships, do not mark new items for propagation + testing-related fixes #1210

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

zenovich
Copy link
Collaborator

@zenovich zenovich commented Nov 7, 2024

  1. Make groups&items propagations twice faster:
  • introduce a new column groups_groups.is_team_membership which equals to 1 when a parent group is a team, set its value automatically on groups_groups creation,
  • move the 'processing' state into a new temporary table,
  • always filter *_propagate tables by exact values of ancestors_propagation_state,
  • perform covering index lookups on groups_groups instead of index lookups (create an index for this).
  1. Do not join the groups table to determine if group memberships (use the new groups_groups.is_team_membership column instead).
  2. Do not mark new items for propagation, only call the items propagation in itemCreate if at least one items_items row is created.
  3. Disallow modifying groups.type and groups_groups.is_team_membership.
  4. Change the DB username for migration-tests to match the definer of triggers in the dump file.
  5. Sort all the data returned by currentUserDataExport & currentUserFullDataExport to make tests stable.

… state into a new temporary table, 2) always filter *_propagate tables by exact values of ancestors_propagation_state, 3) perform covering index lookups on groups_groups instead of index lookups (create an index for this)
… marking a newly created item as "todo" for items propagation, only call the items propagation in itemCreate if new items_items rows are created
@zenovich zenovich added Type: Maintenance Change required to improve the tech debt Type: Perf Performance improvement labels Nov 7, 2024
@zenovich zenovich requested a review from smadbe November 7, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Change required to improve the tech debt Type: Perf Performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant