Add 3d rotations #93
Merged
Add 3d rotations #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds 3D support to the Rotate transformation, and introduces RotateX, RotateY, and RotateZ for 3D rotations around the x, y, and z axes.
Ensure the number of transforms equals the number of random states. Previously, the projection would silently be calculated only for the number of transforms equal to the number of random states.
|
Thanks! Could you add to the documentation in |
* Use `@docs; canonical=false` for documentation outside of ref.md. This allows documentation to exist on a second page. Previously, documentation was split between multiple pages. Some were in ref.md, and some were in other pages (transformations.md, buffering.md). Now, all documentation is at least in ref.md, but can also be duplicated on other pages with `canonical=false`. * Add missing documentation to ref.md, and transformations.md. * Enable the visualizations in gallery.md, and clean up the code a bit. * Add visualizations in gallery.md for 3D rotations.
Hi @CarloLucibello, thanks for taking a look. I just pushed two commits. The first commit is probably what you were looking for, just adding the documentation to ref.md. In a second commit, I went much further with a bit of reorganization, but maybe not what you wanted. I can pull this commit out into a separate PR if that makes more sense. |
|
I like the reorganization! still something to do or we can merge? |
CarloLucibello
approved these changes
Jul 21, 2024
|
@CarloLucibello I am all done with this, you can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 3D support to the Rotate transformation, and introduces
RotateX, RotateY, and RotateZ for 3D rotations around the x, y, and z
axes.
PR Checklist