Begin applying use-case tokens to o3 components. #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
2025-release-apply-type-usecases-o3
to
2025-release
January 14, 2025 16:04
notlee
requested review from
ft-dependency-auto-merger and
a team
as code owners
o3-editorial-typography-pullquote-content have the wrong values – this needs to be updated in Token Studio and applied in Figma. Feedback left for the design team. Moving on for now.
notlee
force-pushed
the
2025-release-apply-type-usecases-o3-2
branch
from
9bd1a78 to
d08e6e6
Compare
frshwtr
reviewed
Jan 15, 2025
| font-size: var(--o3-typography-use-case-label-font-size); | ||
| font-weight: var(--o3-typography-use-case-label-font-weight); | ||
| line-height: var(--o3-typography-use-case-label-line-height); | ||
| text-transform: var(--o3-typography-use-case-label-text-case); |
There was a problem hiding this comment.
This token is undefined, is this expected?
There was a problem hiding this comment.
Good spot, I think you mean --o3-typography-use-case-detail-text-case? I've removed that
frshwtr
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1923 with:
Note that
o3-editorial-typography-pullquote-contenttokens have the wrong values – this needs to be updated in Token Studio and applied in Figma. Feedback left for the design team. Moving on for now.