Begin applying use-case tokens to o3 components. #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases mobile font size. Adds `strong` and `em` styling to direct children. The token `body-content-highlight` font weight is coming through as text `Bold`. I have asked the design team to take a look. `body-highlight` is correct, it's coming through as a reference to an `o3-font-weight` value. Moving on in the meantime.
Apply correct tokens and rename to "display" according to our new design guidelines. Rename JSX component "Headline" to "Heading". It accepts a prop "type" which can be "display", "headline", etc. `<Headline type="headline" >` made little sense. I would prefer these to be seperate components as the style may be applied outside of a heading context, but this rename is pragmatic given our hard deadline
frshwtr
reviewed
Jan 14, 2025
components/o3-editorial-typography/stories/whitelable/headline.stories.tsx
Show resolved
Hide resolved
frshwtr
reviewed
Jan 14, 2025
components/o3-editorial-typography/stories/sustainable-views/headline.stories.tsx
Show resolved
Hide resolved
|
Looks like there's some missing tokens in whitelabel |
j-mes
reviewed
Jan 14, 2025
apps/for-everyone-website/src/components/editorial-typography/HeadlineLarge.astro
Outdated
Show resolved
Hide resolved
frshwtr
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the JSX component
HeadlinetoHeading. It accepts a prop "type" of "headline", "chapter", etc. As Headline is a type of heading,<Headline type="headline" >, this was confusing. I would prefer these to be separate components as the style may be applied outside of a heading context, but this rename is pragmatic given our hard deadline.I chose to stop and open a PR here since it was getting chunky and will continue applying use-case tokens to other
Headingtypes in a follow on PR.