Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove current edition and change cross style #1725

Merged
merged 26 commits into from
Jul 5, 2024
Merged

feat: remove current edition and change cross style #1725

merged 26 commits into from
Jul 5, 2024

Conversation

danieleruiz
Copy link
Contributor

@danieleruiz danieleruiz commented Jun 18, 2024 •
edited
Loading

Describe your changes

Due to the redesign initiative of the search bar navigation, the current edition will become part of the "edition-switcher" component of dotcom-page-kit.

Changes:

  • Move the close icon to the left side
  • Remove the logo
  • Update the style of the edition switcher
  • Modify the style of the search bar and search button
  • Change the placeholder text

Issue ticket number and link

https://financialtimes.atlassian.net/browse/CON-3426

Link to Figma designs

https://www.figma.com/design/L6qyUFPPLRmf59OxTkz2VJ/Semantic-Search?node-id=279-91827&m=dev

Screenshots:

Before:
image

After:
image

Checklist before requesting a review

  • I have applied percy label for o-[COMPONENT] or chromatic label for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md

@danieleruiz danieleruiz requested a review from a team as a code owner June 18, 2024 08:43
@notlee notlee temporarily deployed to origami-webs-con-3426-s-3qqq1r June 18, 2024 08:47 Inactive
@danieleruiz danieleruiz added the percy This will tell the percy github action to run label Jun 18, 2024
@notlee notlee temporarily deployed to origami-webs-con-3426-s-3qqq1r June 18, 2024 09:03 Inactive
@notlee notlee temporarily deployed to origami-webs-con-3426-s-3qqq1r June 18, 2024 09:08 Inactive
@notlee notlee temporarily deployed to origami-webs-con-3426-s-3qqq1r June 19, 2024 14:04 Inactive
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 2, 2024 08:01 Inactive
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 2, 2024 08:06 Inactive
@danieleruiz danieleruiz requested a review from frshwtr July 2, 2024 08:12
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 2, 2024 08:13 Inactive
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 2, 2024 10:54 Inactive
@danieleruiz danieleruiz requested a review from notlee July 2, 2024 11:19
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 2, 2024 11:25 Inactive
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 3, 2024 11:14 Inactive
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 3, 2024 14:18 Inactive
@notlee
chore: remove old demos
256e844 
Rely on o-header Storybook Stories instead
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 3, 2024 15:23 Inactive
@notlee
chore: install o-footer as a peer dependency
283a167 
this will ensure a flat dependency tree (one version of o-forms installed
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 3, 2024 15:27 Inactive
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 3, 2024 15:35 Inactive
notlee
notlee requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@notlee notlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vertical spacing on desktop search looks a little off, there is more space above than below:

Screenshot 2024-07-03 at 16 35 58

components/o-header/src/scss/features/_drawer.scss Outdated Show resolved Hide resolved
components/o-header/src/scss/features/_drawer.scss Outdated Show resolved Hide resolved
components/o-header/src/scss/features/_drawer.scss Outdated Show resolved Hide resolved
components/o-header/src/scss/features/_drawer.scss Outdated Show resolved Hide resolved
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 3, 2024 20:09 Inactive
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 3, 2024 20:14 Inactive
@danieleruiz danieleruiz requested a review from notlee July 4, 2024 07:26
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 4, 2024 10:49 Inactive
@notlee notlee temporarily deployed to origami-webs-con-3426-s-zdbuih July 4, 2024 13:33 Inactive
@danieleruiz danieleruiz requested a review from notlee July 4, 2024 14:20
@danieleruiz
Copy link
Contributor Author

The vertical spacing on desktop search looks a little off, there is more space above than below:

Screenshot 2024-07-03 at 16 35 58

fixed it

@notlee notlee merged commit 090d384 into main Jul 5, 2024
9 checks passed
@notlee notlee deleted the CON-3426-searchNavBarRedesign branch July 5, 2024 10:40
@origamiserviceuser origamiserviceuser mentioned this pull request Jul 5, 2024
Merged
This was referenced Jul 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notlee notlee notlee approved these changes

@frshwtr frshwtr Awaiting requested review from frshwtr

Assignees
No one assigned
Labels
percy This will tell the percy github action to run
Projects
Origami ✨
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieleruiz @frshwtr @notlee