CON-3426: design changes ask button, edition switcher, subscribe button #1047
Conversation
packages/dotcom-ui-header/src/components/drawer/additionalPartials.tsx
Outdated
Show resolved
Hide resolved
packages/dotcom-ui-header/src/__test__/components/__snapshots__/Drawer.spec.tsx.snap
Outdated
Show resolved
Hide resolved
I don't know if this is an edge case for us to handle? |
There was a problem hiding this comment.
It look okay to me. Please, take a look at this suggestion #1047 (comment)
Co-authored-by: Artem Metelskyi <[email protected]>
|
Just discussed with Daniel moving these changes to o-header, so non-pagekit projects can incorporate these changes for a consistent header across ft.com |
packages/dotcom-ui-header/src/components/drawer/additionalPartials.tsx
Outdated
Show resolved
Hide resolved
packages/dotcom-ui-header/src/components/drawer/topLevelPartials.tsx
Outdated
Show resolved
Hide resolved
packages/dotcom-ui-header/src/components/drawer/topLevelPartials.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
When I ran your bracnh locally I no longer see the search value inside the search input field. It collides with typeahead from the n-topic-seach. Can you please double check this behavior locally in your dev environment?
Screen.Recording.2024-07-08.at.11.46.43.mov
Co-authored-by: Artem Metelskyi <[email protected]>
|
When tabbing between items in the FT Drawer I get focus on the empty element that represent the FT Logo. This seems wrong Screen.Recording.2024-07-08.at.11.52.06.mov |
| @@ -10,5 +10,6 @@ $system-code: 'page-kit-header' !default; | |||
|
|
|||
| @import "src/header"; | |||
|
|
|||
| @import "n-topic-search/main"; | |||
There was a problem hiding this comment.
issue: Please can we remove the duplicated line?
| @import "n-topic-search/main"; |
There was a problem hiding this comment.
Oh this was fixed! I was too late.
| <span className="o-header__visually-hidden">Close side navigation menu</span> | ||
| </button> | ||
| <a className="o-header__drawer-tools-logo" href="/" data-trackable="logo"> | ||
| <span className="o-header__visually-hidden">Financial Times</span> | ||
| </a> | ||
| {props.current && <p className="o-header__drawer-current-edition">{`${props.current.name} Edition`}</p>} | ||
| {editions && <EditionsSwitcher {...editions} />} |
There was a problem hiding this comment.
suggestion(non-blocking): I like in Origami that it is explicit about passing the current and other editions which is easier to read. We should keep these templates as close to the Origami template as possible. But we have plans to move away from this template in the future (probably in Q1 2025) so no need to do this.
button removed |
Description
As part of search navbar redesign we need to change design and position of ask button, design of edition switcher and position of subscribe button,
Changes from o-header:
Figma:
https://www.figma.com/design/L6qyUFPPLRmf59OxTkz2VJ/Semantic-Search?node-id=10-629&m=dev
o-header changes PR: Financial-Times/origami#1725
Ticket
https://financialtimes.atlassian.net/browse/CON-3426
Screenshots
Before:
After:
