Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backstage: bump o-tracking internal version #1623

Merged
merged 2 commits into from
May 1, 2024
Merged

backstage: bump o-tracking internal version #1623

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
496d48d
backstage: bump o-tracking internal version
danail-s Apr 30, 2024
bb58ce0
fix: update to proper o-tracking version
danail-s Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/o-tracking/src/javascript/tracking.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const initPage = page.init;
*
* @type {string}
*/
const version = '4.5.0';
const version = '4.5.3';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o-tracking is currently 4.5.3 but, when this is released, it'll be 4.5.4 😅

Suggested change
const version = '4.5.3';
const version = '4.5.4';

Copy link
Contributor Author

@danail-s danail-s Apr 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i thought backstage commits don't trigger a new release? Getting my info from here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right! That's correct. However we'll need to release to get the version updated in production. Looks like it's send with tracking events and I guess that's what you want to update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 👍 I'll go ahead and release


/**
* The source of this event.
Expand Down
Loading