Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backstage: bump o-tracking internal version #1623

Merged
merged 2 commits into from
May 1, 2024

Conversation

danail-s
Copy link
Contributor

Describe your changes

Update the internal version of o-tracking

@danail-s danail-s requested a review from a team as a code owner April 30, 2024 11:16
@notlee notlee temporarily deployed to origami-webs-backstage--xp5jxg April 30, 2024 11:20 Inactive
@@ -17,7 +17,7 @@ const initPage = page.init;
*
* @type {string}
*/
const version = '4.5.0';
const version = '4.5.3';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o-tracking is currently 4.5.3 but, when this is released, it'll be 4.5.4 😅

Suggested change
const version = '4.5.3';
const version = '4.5.4';

Copy link
Contributor Author

@danail-s danail-s Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i thought backstage commits don't trigger a new release? Getting my info from here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right! That's correct. However we'll need to release to get the version updated in production. Looks like it's send with tracking events and I guess that's what you want to update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 👍 I'll go ahead and release

@notlee notlee temporarily deployed to origami-webs-backstage--xp5jxg April 30, 2024 15:14 Inactive
@notlee notlee self-requested a review May 1, 2024 13:41
@notlee notlee merged commit 916da0f into main May 1, 2024
7 checks passed
@notlee notlee deleted the backstage/bump-o-tracking-version branch May 1, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants