fix: Basic state broken due to key change #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpatel-figure
commented
Nov 18, 2024
rpatel-figure
requested review from
celloman,
hyperschwartz and
rgipson-figure
|
This version was deployed to testnet in proposal 192 earlier today and then migrated to code ID 990, after which the state for key |
rpatel-figure
changed the title
rpatel-figure
changed the title
rgipson-figure
previously approved these changes
Nov 19, 2024
rgipson-figure
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#78 broke the
state_v2storage. Due to time constraints, implementing the dirty workaround of setting the string to what will yield the correct existing hexadecimal storage key.Changes