Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [sc-341346] Fix broken base state key #79

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rpatel-figure
Copy link
Contributor

@rpatel-figure rpatel-figure commented Nov 18, 2024

Context

#78 broke the state_v2 storage. Due to time constraints, implementing the dirty workaround of setting the string to what will yield the correct existing hexadecimal storage key.

Changes

  • Fix base state storage key
  • Clean up a few lines in the integration test

Copy link
Contributor Author

@rpatel-figure rpatel-figure Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file preview doesn't show 😭

@rpatel-figure rpatel-figure marked this pull request as ready for review November 18, 2024 23:44
@rpatel-figure rpatel-figure requested review from a team as code owners November 18, 2024 23:44
@rpatel-figure rpatel-figure marked this pull request as draft November 18, 2024 23:48
@rpatel-figure rpatel-figure marked this pull request as ready for review November 18, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant