feat: Update to provwasm v2; improve developer experience #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwtalley
reviewed
Nov 13, 2024
kwtalley
reviewed
Nov 13, 2024
|
Squashing commits since the majority were unsuccessful incremental attempts at fixing various issues. None are really particularly valuable in isolation. |
rpatel-figure
force-pushed
the
ravipatel/sc-341346/upgrade-for-provenance-v-1-20
branch
from
2c3dcd5 to
1d344bb
Compare
rpatel-figure
commented
Nov 14, 2024
There was a problem hiding this comment.
The new integration test and example script only cover the single happy path flow of onboarding an asset and then immediately verifying it. With that said, I think we can have confidence that most, if not all flows, will work if this PR were to merge as-is right now. I just have one question about the cosmwasm storage crate change below.
rgipson-figure
added
bug
rgipson-figure
previously approved these changes
Nov 18, 2024
rgipson-figure
approved these changes
Nov 18, 2024
rpatel-figure
deleted the
ravipatel/sc-341346/upgrade-for-provenance-v-1-20
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The contract no longer works in testnet, encountering an error when attempting to look up scopes.
This was possibly directly caused by provenance-io/provwasm#160 and/or provenance-io/provenance#2119.
Changes
Notes