Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CQDG-425 map refseq_mrna_id in variant consequences table #172

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/views/VariantEntity/utils/consequences.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,17 @@ export const getConsequencesProColumn = (): ProColumnType[] => [
title: intl.get('entities.variant.consequences.refSeq'),
dataIndex: 'refseq_mrna_id',
key: 'consequences',
render: (refseq_mrna_id: string) =>
refseq_mrna_id ? (
<ExternalLink href={`https://www.ncbi.nlm.nih.gov/nuccore/${refseq_mrna_id}?report=graph`}>
{refseq_mrna_id}
</ExternalLink>
) : (
TABLE_EMPTY_PLACE_HOLDER
),
render: (refseq_mrna_id: string[]) =>
refseq_mrna_id?.length
? refseq_mrna_id.map((id, index) => (
<ExternalLink
key={index}
href={`https://www.ncbi.nlm.nih.gov/nuccore/${refseq_mrna_id}?report=graph`}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je dis peut être une grosse bétise mais c'est pas plutôt id que tu veux mettre dans l'url sachant que refseq_mrna_id est un tableau ?

Suggested change
href={`https://www.ncbi.nlm.nih.gov/nuccore/${refseq_mrna_id}?report=graph`}
href={`https://www.ncbi.nlm.nih.gov/nuccore/${id}?report=graph`}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non on veut les ids combinés ici

>
{id}
</ExternalLink>
))
: TABLE_EMPTY_PLACE_HOLDER,
width: '10%',
},
];