feat: CQDG-425 map refseq_mrna_id in variant consequences table #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulous
requested review from
adipaul1981,
claudia1296,
evans-g-crsj,
celinepelletier and
AltefrohneGaelle
| ? refseq_mrna_id.map((id, index) => ( | ||
| <ExternalLink | ||
| key={index} | ||
| href={`https://www.ncbi.nlm.nih.gov/nuccore/${refseq_mrna_id}?report=graph`} |
There was a problem hiding this comment.
Je dis peut être une grosse bétise mais c'est pas plutôt id que tu veux mettre dans l'url sachant que refseq_mrna_id est un tableau ?
Suggested change
| href={`https://www.ncbi.nlm.nih.gov/nuccore/${refseq_mrna_id}?report=graph`} | |
| href={`https://www.ncbi.nlm.nih.gov/nuccore/${id}?report=graph`} |
There was a problem hiding this comment.
Non on veut les ids combinés ici
Coverage report
Test suite run success0 tests passing in 0 suite. Report generated by 🧪jest coverage report action from 4f8136c |
AltefrohneGaelle
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: CQDG-425 map refseq_mrna_id in variant consequences table
Description
https://ferlab-crsj.atlassian.net/browse/CQDG-425
Acceptance Criterias
Validation
Screenshot
QA
Steps to validate
Url (storybook, ...)
...
Mention