Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin AgileRL version #1193

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

dm-ackerman
Copy link
Contributor

Description

The new version breaks the tutorial. Pinning to the previous version.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

The new version breaks the tutorial.
@dm-ackerman
Copy link
Contributor Author

I was going to update the files to match the new version of AgileRL, which seemed straightforward. But it ended up also changing the trained models that are in the repo. I don't know whether that is supposed to happen, so I decided to just pin the version instead.

I'm not sure if we actually need those models to be stored in the repo.

@elliottower elliottower merged commit b19c02c into Farama-Foundation:master Mar 20, 2024
47 checks passed
@dm-ackerman dm-ackerman deleted the agilerl_fix branch March 20, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants