-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test to handle nested observation dicts #1172
Merged
elliottower
merged 6 commits into
Farama-Foundation:master
from
dm-ackerman:bugfix_1167
Mar 22, 2024
Merged
Fix test to handle nested observation dicts #1172
elliottower
merged 6 commits into
Farama-Foundation:master
from
dm-ackerman:bugfix_1167
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of the test worked for a dict observation, but not a dict of a dict. This fix will allow observations with unlimited nesting to be correctly tested (at least for the specific test that was failing).
This would be good to get merged but it looks like it failed because int has no dtype? Not sure what that is about |
Tests are failing due to AgileRL version change. #1193 should resolve that. |
elliottower
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me seems to be passing now too
jjshoots
requested changes
Mar 21, 2024
elliottower
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous version of the test worked for a dict observation, but not a dict of a dict. This fix will allow observations with unlimited nesting to be correctly tested (at least for the specific test that was failing).
Fixes #1167, Depends on #1170
Type of change
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.