Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow request managers to delete data from sonarr/radarr #644

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

xabufr
Copy link
Contributor

@xabufr xabufr commented Feb 2, 2024

Description

Allow users who have the MANAGE_REQUESTS right to delete media files.
I've done that on the request list to have a quick access to this feature.

This doesn't need to change the API because the API already only requires MANAGE_REQUESTS for this call.

Screenshot (if UI-related)

image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

Related to:

@xabufr xabufr marked this pull request as ready for review February 2, 2024 22:29
@Panda260
Copy link

Panda260 commented Feb 3, 2024

oh very cool. very nice idea

@Panda260
Copy link

@xabufr who can request a deleting?
Only that person who also requested that same movie/tv show?

@xabufr
Copy link
Contributor Author

xabufr commented Feb 19, 2024

Any person with the MANAGE_REQUESTS can delete any movie/tv show.

@Panda260
Copy link

Any person with the MANAGE_REQUESTS can delete any movie/tv show.

So now a user who has permission could simply delete the requested film from every other user? when he has the rights for that?

@Panda260
Copy link

Wouldn't it be better if everyone could delete their own requested movie or TV shows just as a suggestion

@xabufr
Copy link
Contributor Author

xabufr commented Feb 22, 2024

Any person with the MANAGE_REQUESTS can delete any movie/tv show.

So now a user who has permission could simply delete the requested film from every other user? when he has the rights for that?

Yes, any user that can 'manage requests' can delete any request. That was already the case, this PR just add a button to allow the user to also delete request's data, but it don't modify necessary rights.

Wouldn't it be better if everyone could delete their own requested movie or TV shows just as a suggestion

There is currently no permission to delete you own requests I think (and no button for that), this would require more work, I did this PR as a quick/easy new feature.

Copy link
Contributor

@Gauvino Gauvino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works like a charm, just remove the renaming change on en.json (overseerr to jellyseerr) and the change on fr.json causing weblate trouble please

@xabufr
Copy link
Contributor Author

xabufr commented Apr 18, 2024

@Gauvino I removed the bad commit for the en.json file, but for the new translation keys where should I put them?

@Gauvino
Copy link
Contributor

Gauvino commented Apr 18, 2024

@Gauvino I removed the bad commit for the en.json file, but for the new translation keys where should I put them?

You just keep the translation keys on the en.json, remove the change in fr.json

@xabufr
Copy link
Contributor Author

xabufr commented Apr 18, 2024

done !

@gauthier-th gauthier-th linked an issue Jul 19, 2024 that may be closed by this pull request
1 task
@xabufr
Copy link
Contributor Author

xabufr commented Jul 29, 2024

@Fallenbagel is it good for you?

@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Aug 5, 2024
@Gauvino
Copy link
Contributor

Gauvino commented Aug 10, 2024

Could you refactor this to make it work with the new fetch api please ?

Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your PR to use the Fetch API instead of Axios.

@Gauvino
Copy link
Contributor

Gauvino commented Sep 17, 2024

@xabufr don't know if you missed, but please could you update and use the fetch API? Thanks!

@xabufr
Copy link
Contributor Author

xabufr commented Sep 17, 2024

Yes sorry I completely forget this issue, I'll try to do it this week

Copy link

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label Sep 18, 2024
@github-actions github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Sep 18, 2024
@xabufr
Copy link
Contributor Author

xabufr commented Sep 18, 2024

@Gauvino & @gauthier-th I've made requested changes about fetch API

@gauthier-th gauthier-th added the preview PRs deployed for testing with tag `:preview-prxx` label Sep 30, 2024
@Gauvino
Copy link
Contributor

Gauvino commented Sep 30, 2024

Tested and works as expected with movies and series!

@gauthier-th gauthier-th merged commit a5d22ba into Fallenbagel:develop Sep 30, 2024
9 checks passed
@hellez hellez mentioned this pull request Oct 13, 2024
13 tasks
@Fallenbagel
Copy link
Owner

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview PRs deployed for testing with tag `:preview-prxx` released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let normal users request the deletion of media
5 participants