Skip to content

chore(*): add feature gates for module timing for lara-r6 & toby-r2 (… #113

chore(*): add feature gates for module timing for lara-r6 & toby-r2 (…

chore(*): add feature gates for module timing for lara-r6 & toby-r2 (… #113

GitHub Actions / clippy succeeded Sep 5, 2023 in 0s

clippy

9 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 9
Note 0
Help 0

Versions

  • rustc 1.72.0 (5680fa18f 2023-08-23)
  • cargo 1.72.0 (103a7ff2e 2023-08-15)
  • clippy 0.1.72 (5680fa1 2023-08-23)

Annotations

Check warning on line 130 in ublox-cellular/src/registration.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `act` is never read

warning: field `act` is never read
   --> ublox-cellular/src/registration.rs:130:5
    |
127 | pub struct RegistrationParams {
    |            ------------------ field in this struct
...
130 |     act: RatAct,
    |     ^^^
    |
    = note: `RegistrationParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

Check warning on line 38 in ublox-cellular/src/registration.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods `started` and `updated` are never used

warning: methods `started` and `updated` are never used
  --> ublox-cellular/src/registration.rs:38:12
   |
23 | impl<const TIMER_HZ: u32> CellularRegistrationStatus<TIMER_HZ> {
   | -------------------------------------------------------------- methods in this implementation
...
38 |     pub fn started(&self) -> Option<TimerInstantU32<TIMER_HZ>> {
   |            ^^^^^^^
...
42 |     pub fn updated(&self) -> Option<TimerInstantU32<TIMER_HZ>> {
   |            ^^^^^^^

Check warning on line 42 in ublox-cellular/src/module_timing.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `kill_time` is never used

warning: function `kill_time` is never used
  --> ublox-cellular/src/module_timing.rs:42:8
   |
42 | pub fn kill_time<const TIMER_HZ: u32>() -> Option<TimerDurationU32<TIMER_HZ>> {
   |        ^^^^^^^^^

Check warning on line 33 in ublox-cellular/src/config.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `dtr_pin` is never read

warning: field `dtr_pin` is never read
  --> ublox-cellular/src/config.rs:33:16
   |
31 | pub struct Config<RST, DTR, PWR, VINT> {
   |            ------ field in this struct
32 |     pub(crate) rst_pin: Option<RST>,
33 |     pub(crate) dtr_pin: Option<DTR>,
   |                ^^^^^^^
   |
   = note: `Config` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

Check warning on line 409 in ublox-cellular/src/services/data/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `profile_id`

warning: unused variable: `profile_id`
   --> ublox-cellular/src/services/data/mod.rs:409:52
    |
409 |     fn activate_context(&mut self, cid: ContextId, profile_id: ProfileId) -> nb::Result<(), Error> {
    |                                                    ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_profile_id`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 446 in ublox-cellular/src/network.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> ublox-cellular/src/network.rs:446:13
    |
446 |         let mut new_reg_params: Option<RegistrationParams> = None;
    |             ----^^^^^^^^^^^^^^
    |             |
    |             help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

Check warning on line 1 in ublox-cellular/src/client.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `AtatResp`

warning: unused import: `AtatResp`
 --> ublox-cellular/src/client.rs:1:34
  |
1 | use atat::{blocking::AtatClient, AtatResp};
  |                                  ^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check warning on line 478 in ublox-cellular/src/client.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded sub `cfg` when there is only one condition

warning: unneeded sub `cfg` when there is only one condition
   --> ublox-cellular/src/client.rs:478:15
    |
478 |         #[cfg(any(feature = "toby-r2"))]
    |               ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "toby-r2"`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg

Check warning on line 288 in ublox-cellular/src/client.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded sub `cfg` when there is only one condition

warning: unneeded sub `cfg` when there is only one condition
   --> ublox-cellular/src/client.rs:288:15
    |
288 |         #[cfg(any(feature = "lara-r6"))]
    |               ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "lara-r6"`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
    = note: `#[warn(clippy::non_minimal_cfg)]` on by default