chore(*): add feature gates for module timing for lara-r6 & toby-r2 (… #113
KennethKnudsen97Annotations
10 warnings
|
field `act` is never read:
ublox-cellular/src/registration.rs#L130
warning: field `act` is never read
--> ublox-cellular/src/registration.rs:130:5
|
127 | pub struct RegistrationParams {
| ------------------ field in this struct
...
130 | act: RatAct,
| ^^^
|
= note: `RegistrationParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
|
methods `started` and `updated` are never used:
ublox-cellular/src/registration.rs#L38
warning: methods `started` and `updated` are never used
--> ublox-cellular/src/registration.rs:38:12
|
23 | impl<const TIMER_HZ: u32> CellularRegistrationStatus<TIMER_HZ> {
| -------------------------------------------------------------- methods in this implementation
...
38 | pub fn started(&self) -> Option<TimerInstantU32<TIMER_HZ>> {
| ^^^^^^^
...
42 | pub fn updated(&self) -> Option<TimerInstantU32<TIMER_HZ>> {
| ^^^^^^^
|
|
function `kill_time` is never used:
ublox-cellular/src/module_timing.rs#L42
warning: function `kill_time` is never used
--> ublox-cellular/src/module_timing.rs:42:8
|
42 | pub fn kill_time<const TIMER_HZ: u32>() -> Option<TimerDurationU32<TIMER_HZ>> {
| ^^^^^^^^^
|
|
field `dtr_pin` is never read:
ublox-cellular/src/config.rs#L33
warning: field `dtr_pin` is never read
--> ublox-cellular/src/config.rs:33:16
|
31 | pub struct Config<RST, DTR, PWR, VINT> {
| ------ field in this struct
32 | pub(crate) rst_pin: Option<RST>,
33 | pub(crate) dtr_pin: Option<DTR>,
| ^^^^^^^
|
= note: `Config` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
unused variable: `profile_id`:
ublox-cellular/src/services/data/mod.rs#L409
warning: unused variable: `profile_id`
--> ublox-cellular/src/services/data/mod.rs:409:52
|
409 | fn activate_context(&mut self, cid: ContextId, profile_id: ProfileId) -> nb::Result<(), Error> {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_profile_id`
|
= note: `#[warn(unused_variables)]` on by default
|
|
variable does not need to be mutable:
ublox-cellular/src/network.rs#L446
warning: variable does not need to be mutable
--> ublox-cellular/src/network.rs:446:13
|
446 | let mut new_reg_params: Option<RegistrationParams> = None;
| ----^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused import: `AtatResp`:
ublox-cellular/src/client.rs#L1
warning: unused import: `AtatResp`
--> ublox-cellular/src/client.rs:1:34
|
1 | use atat::{blocking::AtatClient, AtatResp};
| ^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unneeded sub `cfg` when there is only one condition:
ublox-cellular/src/client.rs#L478
warning: unneeded sub `cfg` when there is only one condition
--> ublox-cellular/src/client.rs:478:15
|
478 | #[cfg(any(feature = "toby-r2"))]
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "toby-r2"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
|
|
unneeded sub `cfg` when there is only one condition:
ublox-cellular/src/client.rs#L288
warning: unneeded sub `cfg` when there is only one condition
--> ublox-cellular/src/client.rs:288:15
|
288 | #[cfg(any(feature = "lara-r6"))]
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "lara-r6"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
= note: `#[warn(clippy::non_minimal_cfg)]` on by default
|
|
security_audit
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/audit-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|