De-hardcode Shears

[deirn]

Redirects all item == Items.SHEARS from vanilla.
Used this to transform the loot tables (of course i'm not doing that manually)

grep -L '"item": "minecraft:shears"' * | xargs rm -f
grep -rli '"item": "minecraft:shears"' * | xargs -i@ sed -i 's/"item": "minecraft:shears"/"tag": "fabric:shears"/g' @

Closes #1226

[Prospector]

For now, replacing the whole loot table jsons is fine in my opinion, however at some point I think we need a better way to do this, so that any mod can go in and replace stuff like this in a way that would allow for multiple mods to work on the same loot table.

[deirn]

That sounds like a nightmare to support :P

[OroArmor]

maybe it would make sense to mixin to where the condition is checked, then to see if its shears then to check if its in the tag rather than change the loottables

[deirn]

I believe I could mixin to MatchToolLootCondition#test. The upside is it'll transform any loot tables, but then there won't be a way to check only for vanilla shears. I looked around on forge and it just replaces the loot table like I did.

[OroArmor]

hm thats a good point. however, im not sure why someone would want something specific to the vanilla shears. There also might be a way to add another condition that forces the item in that case, but this feels hacky. The idea of transforming the loottables isn't bad, i was just hoping there would be a better way in code to do so.

[Prospector]

I definitely think Fabric should only ever touch vanilla loot tables, not modded ones, what I was mainly talking about would be allowing multiple other mods to make similar modifications to vanilla loot tables. For example, one mod that changed a drop, and another that changed a condition. However, as I said, out of scope for this PR.

[maityyy]

For leaves/cobweb loot tables, etc., you can use Fabric Loot Table API v1 or wait for new v2. Would be a good test for @Juuxel

[deirn]

As Prospector said, there's currently no easy way to modify entries via code. Adding a new pool with same result won't work since there will be duplicates. https://youtu.be/9zXBNFLADGg

[liach]

Guess we will write a loot table visitor, like the tree visitors used by asm, javac api and all those cool stuff?

[RedstoneParadox]

Guess we will write a loot table visitor, like the tree visitors used by asm, javac api and all those cool stuff?

Is anyone currently working on that?

Edit: I mean if no one is, I can work on that.

[kanpov]

rip stale fabric pr number 1996894

[Juuxel]

As Prospector said, there's currently no easy way to modify entries via code. Adding a new pool with same result won't work since there will be duplicates. https://youtu.be/9zXBNFLADGg

@deirn I think that can be done with #1241's LootTableEvents.REPLACE if you actually implement the entry modification yourself. (Just iterate through the pools and replace whatever's needed, then construct a new table and replace the old one)

[Technici4n]

Wouldn't that require a way to not modify "manual" loot tables? We probably want users to be able to override our changes. Can't we use datagen to replace vanilla's tables?

[Juuxel]

Wouldn't that require a way to not modify "manual" loot tables?

Yeah, and that's an issue with the loot api in general; see Fabricord #api.

Can't we use datagen to replace vanilla's tables?

How do we ensure that FAPI's "augmented" vanilla loot tables are not loaded instead of loot tables in other mods? If a mod makes an actual replacement for the loot table, that should be preferred over that sort of compat replacement.

[Technici4n]

No idea how we could prevent that tbh. Possibly with a resource condition that allows other mods to disable our tables?

[AnAwesomGuy]

would love this, as im currently trying to make a mod that adds stone shears

[Technici4n]

Would be interesting to see how Forge addresses this.

[deirn]

Last time I looked at Forge it just replaced the loot tables.

[Technici4n]

That seems fine by me, we could likely datagen them.

[AnAwesomGuy]

https://github.com/OroArmorModding/Multi-Item-Lib/
https://github.com/VazkiiMods/Botania/blob/1.19.x/Fabric/src/main/java/vazkii/botania/fabric/mixin/ItemPredicateFabricMixin.java

[DaFuqs]

Multi-Item-Lib does not handle loot tables, it seems like.
IMO, instead of using an in-code registry like done in Multi-Item-Lib, items should be put in a tag instead, like c:shears for easier backwards compatility and matching the vanilla way, like other tools like pickaxes are handled.