Loot table Visitors [WIP] #1327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
added
enhancement
Juuxel
reviewed
Feb 22, 2021
| @@ -0,0 +1,65 @@ | |||
| package net.fabricmc.fabric.api.loot.v1.visitor; | |||
|
|
|||
| public interface LootTableVisitor { | |||
There was a problem hiding this comment.
I think this needs some defaults 😄
There was a problem hiding this comment.
Yes, definitely, once I add methods to nodes that allow getting their children, which will come once I add the dozens of different nodes required for all vanilla functions, loot conditions, and whatever else I deem necessary.
Closed
|
If anyone wants to take over this, be my guest. I no longer have an interest in continuing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to provide a way to directly modify certain aspects vanilla loot tables without having to write complex boilerplate or replace the whole thing (See #1287). This is done using the visitor pattern to avoid coupling the algorithm to the structure of the loot table in the event it changes.
This PR is nowhere near done and is only being opened so people are aware that it's being worked on and can comment on it.