Arm subsystem #52
Merged
Arm subsystem #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oder, make open loop control.
m10653
reviewed
Jan 19, 2024
|
Do we want to use the embedded PID controller inside of the spark max for better performance? one downside is it makes simulation a bit hard/annoying to do. Edit lets deal with just profiled pid loop for now and later do the onboard pid controller. |
Lu-han-wang
force-pushed
the
36-Basic-Arm
branch
from
f58057b
to
d0db4cf
Compare
m10653
force-pushed
the
36-Basic-Arm
branch
2 times, most recently
from
5df5816
to
d0db4cf
Compare
m10653
approved these changes
Jan 29, 2024
src/main/java/org/jmhsrobotics/frc2024/subsystems/arm/ArmClosedCommand.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36