Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Aarch64 GCC >= 10.1 warnings #1185

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Suppress Aarch64 GCC >= 10.1 warnings #1185

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af0eaf7
failed attempt to suppress aarch c++17 gcc10.1 note with pragma ignored
ptheywood Feb 15, 2024
580084c
Revert "failed attempt to suppress aarch c++16 gcc10.1 note with prag…
ptheywood Feb 15, 2024
ee9ffe7
Suppress psABI warnings in GCC >= 10.1 on aarch64
ptheywood Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cmake/warnings.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,13 @@ if(NOT COMMAND flamegpu_suppress_some_compiler_warnings)
if(CMAKE_CUDA_COMPILER_VERSION VERSION_GREATER_EQUAL 11.6.0)
target_compile_definitions(${SSCW_TARGET} PRIVATE "__CDPRT_SUPPRESS_SYNC_DEPRECATION_WARNING")
endif()
else()
# Linux specific warning suppressions
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
# GCC specific warning suppressions
# GCC 10.1 AARCH specific ps ABI warnings in C++17 mode. See https://github.com/FLAMEGPU/FLAMEGPU2/issues/1176
if(CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64" AND CMAKE_CUDA_COMPILER_VERSION VERSION_GREATER_EQUAL 10.1.0)
target_compile_options(${SSCW_TARGET} PRIVATE "$<$<COMPILE_LANGUAGE:CUDA>:SHELL:-Xcompiler -Wno-psabi>")
target_compile_options(${SSCW_TARGET} PRIVATE "$<$<COMPILE_LANGUAGE:C,CXX>:-Wno-psabi>")
endif()
endif()
# Generic OS/host compiler warning suppressions
# Ensure NVCC outputs warning numbers
Expand Down
Loading