Suppress Aarch64 GCC >= 10.1 warnings #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ma ignored" This reverts commit af0eaf7.
Unfortunatley supressing this via pragmas around the effected code was unsuccessful
Robadob
approved these changes
Feb 15, 2024
Not yet, we potentially can by emulating it with cmake cross compilation or QEMU that might allow us to make aarch python wheels, but that will take more time than I have right now (issue #1174). I did make sure that I used the CMake var for the architecture that matches the target not the host during cross compilation too. |
|
Ah fair, well I assume you've tested it given the multiple commits
…On Fri, 16 Feb 2024, 10:59 Peter Heywood, ***@***.***> wrote:
Iirc, you added this processor arch to CI? (hard to check on my phone in
parallel). So should be fine.
Not yet, we potentially can by emulating it with QEMU that might allow us
to make aarch python wheels, but that will take more time than I have right
now (issue #1174 <#1174>)
—
Reply to this email directly, view it on GitHub
<#1185 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVGCXDKDZJWYHPOMFGEITYT43YLAVCNFSM6AAAAABDKUUONSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBYGE4DAMJSHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Yep, tested manually on a grace-hopper node, with 2 versions of GCC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppresses psABI warnings on aarch64 using GCC >= 10.1.
Unfortunately had to be applied project-wide as
#pragma GCC diagnostic ignored "-Wpsabi"did not work (Attempt and reversion left in the PR for reference, but should be squash merged).Closes #1176