rewrite ROL/ROR #3539
Merged
rewrite ROL/ROR #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will come up with rotate in the next patch Signed-off-by: Alyssa Rosenzweig <[email protected]>
more correct for rcl, etc Signed-off-by: Alyssa Rosenzweig <[email protected]>
This was referenced Mar 31, 2024
single unified implementation for ROL & ROR (instead of 4 cases). no more deferred flags because it's easy to shoot ourselves in the foot with deferred flags w.r.t the new RA design, and rotates are rare enough with very efficient flag calculations such that the extra JIT overhead should be minimal to DCE the resulting calculations later. Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
alyssarosenzweig
force-pushed
the
ra/rol-ror2
branch
from
ab5eb5d to
2aa1fd7
Compare
Sonicadvance1
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single unified implementation for ROL & ROR (instead of 4 cases). no more
deferred flags because it's easy to shoot ourselves in the foot with deferred
flags w.r.t the new RA design, and rotates are rare enough with very efficient
flag calculations such that the extra JIT overhead should be minimal to DCE the
resulting calculations later.