Library Forwarding: Test interaction of struct repacking and assume_compatible_data_layout #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neobrain
force-pushed
the
feature_thunk_test_repack_vs_assume_compatible
branch
2 times, most recently
from
7530146 to
53c4d59
Compare
…_compatible_data_layout
The -deps target is the wrong target to add this to, since its compile flags are propagated to both Guest.cpp and Host.cpp. Instead, define the flag only when processing files within a guest context.
neobrain
force-pushed
the
feature_thunk_test_repack_vs_assume_compatible
branch
from
53c4d59 to
b08d372
Compare
|
Rebased now that the custom repacking code is merged. |
Sonicadvance1
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #3373 merged first.This just adds one more test to test the interaction between automatic struct repacking (added in #3371) and the previously added
assume_compatible_data_layoutannotation (#3177). This serves mainly as a consistency check to ensure other tests don't just pass "by accident".While developing this, I also found that we aren't setting up
GUEST_THUNK_LIBRARYproperly, which the test library needs to enable guest-specific behavior however. A fix for this is included in the PR now as well.